Rename CFX_ByteTextBuf::GetByteString() to AsStringC().

Rename CFX_ByteTextBuf::GetByteString() to AsStringC().

Do the same for CFX_WideTextBuf as well.
The name is confusing because these return CFX_ByteStringC,
not CFX_ByteString.  The AsStringC naming gives parallelism with
the string types themselves, and may help to indicate that
the result is only good for the lifetime of the object being
operated upon.

Committed: https://pdfium.googlesource.com/pdfium/+/8e4c505ff6d82263183e9f812fcc7b45c1414f15

[Tom Sepez, 2016-04-14 20:19:08]

Description was changed from

==========
Rename CFX_ByteTextBuf::GetByteString() to AsStringC().

Do the same for CFX_WideTextBuf as well.
The name is confusing because these return CFX_ByteStringCs,
not CFX_ByteStrings.  The As* naming gives parallelism with
the string types themselves, and may help to indicate that
the result is only good for the lifetime of the object being
operated upon.
==========

to

==========
Rename CFX_ByteTextBuf::GetByteString() to AsStringC().

Do the same for CFX_WideTextBuf as well.
The name is confusing because these return CFX_ByteStringC,
not CFX_ByteString.  The AsStringC naming gives parallelism with
the string types themselves, and may help to indicate that
the result is only good for the lifetime of the object being
operated upon.
==========

[Tom Sepez, 2016-04-14 20:19:08]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-04-14 20:19:20]

Dan, straight rename.

[Tom Sepez, 2016-04-14 20:21:08]

https://codereview.chromium.org/1886263003/diff/1/core/fpdfapi/fpdf_page/fpdf...
File core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp (right):

https://codereview.chromium.org/1886263003/diff/1/core/fpdfapi/fpdf_page/fpdf...
core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp:565: return buf.AsStringC();
note: this will make more sense and seem less dangerous with regards to lifetime
once CFX_ByteString's ctor is explicit, and we need to surround this with a call
to it, rather than just letting conversion to the result type occur implicilty. 
eg. there's an implicit alloc here.

[dsinclair, 2016-04-14 20:42:15]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-04-14 20:42:15]

lgtm

[commit-bot: I haz the power, 2016-04-14 20:42:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1886263003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1886263003/1

[commit-bot: I haz the power, 2016-04-14 20:42:49]

Description was changed from

==========
Rename CFX_ByteTextBuf::GetByteString() to AsStringC().

Do the same for CFX_WideTextBuf as well.
The name is confusing because these return CFX_ByteStringC,
not CFX_ByteString.  The AsStringC naming gives parallelism with
the string types themselves, and may help to indicate that
the result is only good for the lifetime of the object being
operated upon.
==========

to

==========
Rename CFX_ByteTextBuf::GetByteString() to AsStringC().

Do the same for CFX_WideTextBuf as well.
The name is confusing because these return CFX_ByteStringC,
not CFX_ByteString.  The AsStringC naming gives parallelism with
the string types themselves, and may help to indicate that
the result is only good for the lifetime of the object being
operated upon.

Committed:
https://pdfium.googlesource.com/pdfium/+/8e4c505ff6d82263183e9f812fcc7b45c141...
==========

[commit-bot: I haz the power, 2016-04-14 20:42:49]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/8e4c505ff6d82263183e9f812fcc7b45c141...