Rename CFX_ByteTextBuf::GetByteString() to AsStringC().

core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/fpdfapi/fpdf_page/pageint.h"
 
 #include <limits.h>
 
@@ skipping 544 matching lines @@
   int status = 0;
   int iEscCode = 0;
   while (1) {
     switch (status) {
       case 0:
         if (ch == ')') {
           if (parlevel == 0) {
             if (buf.GetLength() > MAX_STRING_LENGTH) {
               return CFX_ByteString(buf.GetBuffer(), MAX_STRING_LENGTH);
             }
-            return buf.GetByteString();
+            return buf.AsStringC();

[Tom Sepez, 2016/04/14 20:21:08]

note: this will make more sense and seem less dangerous with regards to lifetime
once CFX_ByteString's ctor is explicit, and we need to surround this with a call
to it, rather than just letting conversion to the result type occur implicilty. 
eg. there's an implicit alloc here.

           }
           parlevel--;
           buf.AppendChar(')');
         } else if (ch == '(') {
           parlevel++;
           buf.AppendChar('(');
         } else if (ch == '\\') {
           status = 1;
         } else {
           buf.AppendChar((char)ch);
@@ skipping 58 matching lines @@
       break;
 
     ch = m_pBuf[m_Pos++];
   }
   if (PositionIsInBounds())
     ++m_Pos;
 
   if (buf.GetLength() > MAX_STRING_LENGTH) {
     return CFX_ByteString(buf.GetBuffer(), MAX_STRING_LENGTH);
   }
-  return buf.GetByteString();
+  return buf.AsStringC();
 }
 
 CFX_ByteString CPDF_StreamParser::ReadHexString() {
   if (!PositionIsInBounds())
     return CFX_ByteString();
 
   CFX_ByteTextBuf buf;
   bool bFirst = true;
   int code = 0;
   while (PositionIsInBounds()) {
@@ skipping 13 matching lines @@
       buf.AppendByte((uint8_t)code);
     }
     bFirst = !bFirst;
   }
   if (!bFirst)
     buf.AppendChar((char)code);
 
   if (buf.GetLength() > MAX_STRING_LENGTH)
     return CFX_ByteString(buf.GetBuffer(), MAX_STRING_LENGTH);
 
-  return buf.GetByteString();
+  return buf.AsStringC();
 }
 
 bool CPDF_StreamParser::PositionIsInBounds() const {
   return m_Pos < m_Size;
 }
 
 CPDF_ContentParser::CPDF_ContentParser()
     : m_Status(Ready),
       m_InternalStage(STAGE_GETCONTENT),
       m_pObjectHolder(nullptr),
@@ skipping 196 matching lines @@
       }
       m_Status = Done;
       return;
     }
     steps++;
     if (pPause && pPause->NeedToPauseNow()) {
       break;
     }
   }
 }