Rename CFX_ByteTextBuf::GetByteString() to AsStringC().

core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

Index: core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp
diff --git a/core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp b/core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp
index 940881bacbbe2aae96b0c06846fa84b8a3a22053..cf29aa268441e21061d4e42e29db6150b44dbb74 100644
--- a/core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp
+++ b/core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp
@@ -562,7 +562,7 @@ CFX_ByteString CPDF_StreamParser::ReadString() {
             if (buf.GetLength() > MAX_STRING_LENGTH) {
               return CFX_ByteString(buf.GetBuffer(), MAX_STRING_LENGTH);
             }
-            return buf.GetByteString();
+            return buf.AsStringC();

[Tom Sepez, 2016/04/14 20:21:08]

note: this will make more sense and seem less dangerous with regards to lifetime
once CFX_ByteString's ctor is explicit, and we need to surround this with a call
to it, rather than just letting conversion to the result type occur implicilty. 
eg. there's an implicit alloc here.

           }
           parlevel--;
           buf.AppendChar(')');
@@ -641,7 +641,7 @@ CFX_ByteString CPDF_StreamParser::ReadString() {
   if (buf.GetLength() > MAX_STRING_LENGTH) {
     return CFX_ByteString(buf.GetBuffer(), MAX_STRING_LENGTH);
   }
-  return buf.GetByteString();
+  return buf.AsStringC();
 }
 
 CFX_ByteString CPDF_StreamParser::ReadHexString() {
@@ -675,7 +675,7 @@ CFX_ByteString CPDF_StreamParser::ReadHexString() {
   if (buf.GetLength() > MAX_STRING_LENGTH)
     return CFX_ByteString(buf.GetBuffer(), MAX_STRING_LENGTH);
 
-  return buf.GetByteString();
+  return buf.AsStringC();
 }
 
 bool CPDF_StreamParser::PositionIsInBounds() const {