Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1884743002: Convert a few components from scoped_ptr to std::unique_ptr (Closed)

Created:
4 years, 8 months ago by Lei Zhang
Modified:
4 years, 8 months ago
Reviewers:
dcheng
CC:
chromium-reviews, darin-cc_chromium.org, jam, sadrul, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert a few components from scoped_ptr to std::unique_ptr - os_crypt - pdf - printing - storage_monitor BUG=554298 Committed: https://crrev.com/532924d626b6538b547fd00793f0373bb5271df2 Cr-Commit-Position: refs/heads/master@{#386877}

Patch Set 1 #

Patch Set 2 : lint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -118 lines) Patch
M components/crash/content/app/breakpad_win.cc View 1 6 chunks +6 lines, -6 lines 0 comments Download
M components/crash/content/app/crash_keys_win.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/crash/content/app/crashpad_win.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/crash/content/app/run_as_crashpad_handler_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/crash/content/browser/crash_handler_host_linux.h View 3 chunks +5 lines, -5 lines 0 comments Download
M components/crash/content/browser/crash_handler_host_linux.cc View 6 chunks +12 lines, -10 lines 0 comments Download
M components/crash/content/browser/crash_micro_dump_manager_android.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/crash/content/browser/crash_micro_dump_manager_android.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/os_crypt/ie7_password_win.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M components/os_crypt/os_crypt_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M components/os_crypt/os_crypt_posix.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M components/pdf/browser/pdf_web_contents_helper.h View 3 chunks +7 lines, -6 lines 0 comments Download
M components/pdf/browser/pdf_web_contents_helper.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/printing/renderer/print_web_view_helper.h View 5 chunks +7 lines, -7 lines 0 comments Download
M components/printing/renderer/print_web_view_helper.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M components/printing/renderer/print_web_view_helper_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M components/printing/test/mock_printer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/printing/test/print_mock_render_thread.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/printing/test/print_test_content_renderer_client.cc View 1 3 chunks +5 lines, -3 lines 0 comments Download
M components/storage_monitor/media_transfer_protocol_device_observer_linux_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M components/storage_monitor/portable_device_watcher_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/storage_monitor/storage_monitor.h View 4 chunks +4 lines, -4 lines 0 comments Download
M components/storage_monitor/storage_monitor.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/storage_monitor/storage_monitor_chromeos.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/storage_monitor/storage_monitor_chromeos_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M components/storage_monitor/storage_monitor_linux.h View 5 chunks +8 lines, -8 lines 0 comments Download
M components/storage_monitor/storage_monitor_linux.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M components/storage_monitor/storage_monitor_linux_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M components/storage_monitor/storage_monitor_mac.h View 1 3 chunks +4 lines, -2 lines 0 comments Download
M components/storage_monitor/storage_monitor_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M components/storage_monitor/storage_monitor_mac_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M components/storage_monitor/storage_monitor_win.h View 2 chunks +4 lines, -3 lines 0 comments Download
M components/storage_monitor/storage_monitor_win_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/storage_monitor/test_storage_monitor.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/storage_monitor/test_storage_monitor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/storage_monitor/test_volume_mount_watcher_win.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/storage_monitor/udev_util_linux.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Lei Zhang
All the components that I'm OWNER for.
4 years, 8 months ago (2016-04-12 19:42:18 UTC) #2
dcheng
lgtm
4 years, 8 months ago (2016-04-12 21:30:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884743002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884743002/20001
4 years, 8 months ago (2016-04-12 21:42:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/203877)
4 years, 8 months ago (2016-04-12 23:32:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884743002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884743002/20001
4 years, 8 months ago (2016-04-12 23:56:03 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-13 00:37:43 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 00:38:51 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/532924d626b6538b547fd00793f0373bb5271df2
Cr-Commit-Position: refs/heads/master@{#386877}

Powered by Google App Engine
This is Rietveld 408576698