Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: components/crash/content/browser/crash_micro_dump_manager_android.h

Issue 1884743002: Convert a few components from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: lint Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_CRASH_CONTENT_BROWSER_CRASH_MICRO_DUMP_MANAGER_ANDROID_H_ 5 #ifndef COMPONENTS_CRASH_CONTENT_BROWSER_CRASH_MICRO_DUMP_MANAGER_ANDROID_H_
6 #define COMPONENTS_CRASH_CONTENT_BROWSER_CRASH_MICRO_DUMP_MANAGER_ANDROID_H_ 6 #define COMPONENTS_CRASH_CONTENT_BROWSER_CRASH_MICRO_DUMP_MANAGER_ANDROID_H_
7 7
8 #include <map> 8 #include <map>
9 #include <memory>
9 10
10 #include "base/files/scoped_file.h" 11 #include "base/files/scoped_file.h"
11 #include "base/memory/scoped_ptr.h"
12 #include "base/memory/singleton.h" 12 #include "base/memory/singleton.h"
13 #include "base/memory/weak_ptr.h" 13 #include "base/memory/weak_ptr.h"
14 #include "base/process/kill.h" 14 #include "base/process/kill.h"
15 #include "base/sync_socket.h" 15 #include "base/sync_socket.h"
16 #include "base/synchronization/lock.h" 16 #include "base/synchronization/lock.h"
17 #include "content/public/browser/notification_observer.h" 17 #include "content/public/browser/notification_observer.h"
18 #include "content/public/browser/notification_registrar.h" 18 #include "content/public/browser/notification_registrar.h"
19 19
20 namespace breakpad { 20 namespace breakpad {
21 21
(...skipping 29 matching lines...) Expand all
51 // Called on child process exit (including crash). 51 // Called on child process exit (including crash).
52 void HandleChildTerminationOnFileThread( 52 void HandleChildTerminationOnFileThread(
53 int child_process_id, 53 int child_process_id,
54 base::TerminationStatus termination_status); 54 base::TerminationStatus termination_status);
55 55
56 content::NotificationRegistrar notification_registrar_; 56 content::NotificationRegistrar notification_registrar_;
57 57
58 // This map should only be accessed with its lock aquired as it is accessed 58 // This map should only be accessed with its lock aquired as it is accessed
59 // from the PROCESS_LAUNCHER, FILE, and UI threads. 59 // from the PROCESS_LAUNCHER, FILE, and UI threads.
60 base::Lock child_process_id_to_pipe_lock_; 60 base::Lock child_process_id_to_pipe_lock_;
61 std::map<int, scoped_ptr<base::SyncSocket>> child_process_id_to_pipe_; 61 std::map<int, std::unique_ptr<base::SyncSocket>> child_process_id_to_pipe_;
62 base::WeakPtrFactory<CrashMicroDumpManager> weak_factory_; 62 base::WeakPtrFactory<CrashMicroDumpManager> weak_factory_;
63 63
64 DISALLOW_COPY_AND_ASSIGN(CrashMicroDumpManager); 64 DISALLOW_COPY_AND_ASSIGN(CrashMicroDumpManager);
65 }; 65 };
66 66
67 } // namespace breakpad 67 } // namespace breakpad
68 68
69 #endif // COMPONENTS_CRASH_CONTENT_BROWSER_CRASH_MICRO_DUMP_MANAGER_ANDROID_H_ 69 #endif // COMPONENTS_CRASH_CONTENT_BROWSER_CRASH_MICRO_DUMP_MANAGER_ANDROID_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698