components/storage_monitor/storage_monitor_mac.mm - Issue 1884743002: Convert a few components from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/storage_monitor/storage_monitor_mac.mm

Issue 1884743002: Convert a few components from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: lint Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/storage_monitor/storage_monitor_mac.h ('k') | components/storage_monitor/storage_monitor_mac_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/storage_monitor/storage_monitor_mac.mm

diff --git a/components/storage_monitor/storage_monitor_mac.mm b/components/storage_monitor/storage_monitor_mac.mm

index 1ae2c832f9699fc466b8cb68c6ffd35870de2783..7a658fb211b6bec42d7080044c79fdc69a4062c5 100644

--- a/components/storage_monitor/storage_monitor_mac.mm

+++ b/components/storage_monitor/storage_monitor_mac.mm

@@ -135,7 +135,7 @@ struct EjectDiskOptions {

void PostEjectCallback(DADiskRef disk,

DADissenterRef dissenter,

void* context) {

- scoped_ptr<EjectDiskOptions> options_deleter(

+ std::unique_ptr<EjectDiskOptions> options_deleter(

static_cast<EjectDiskOptions*>(context));

if (dissenter) {

options_deleter->callback.Run(StorageMonitor::EJECT_IN_USE);

@@ -148,7 +148,7 @@ void PostEjectCallback(DADiskRef disk,

void PostUnmountCallback(DADiskRef disk,