Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: components/crash/content/browser/crash_micro_dump_manager_android.cc

Issue 1884743002: Convert a few components from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: lint Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/crash/content/browser/crash_micro_dump_manager_android.cc
diff --git a/components/crash/content/browser/crash_micro_dump_manager_android.cc b/components/crash/content/browser/crash_micro_dump_manager_android.cc
index 6ac6c3a09b26ce47ff166e01c7ae2ce2c53c32b1..cfb4b1c2d758faf9049a7da33ddd9f20265483a1 100644
--- a/components/crash/content/browser/crash_micro_dump_manager_android.cc
+++ b/components/crash/content/browser/crash_micro_dump_manager_android.cc
@@ -42,8 +42,8 @@ CrashMicroDumpManager::~CrashMicroDumpManager() {
base::ScopedFD CrashMicroDumpManager::CreateCrashInfoChannel(
int child_process_id) {
DCHECK_CURRENTLY_ON(BrowserThread::PROCESS_LAUNCHER);
- scoped_ptr<base::SyncSocket> local_pipe(new base::SyncSocket());
- scoped_ptr<base::SyncSocket> child_pipe(new base::SyncSocket());
+ std::unique_ptr<base::SyncSocket> local_pipe(new base::SyncSocket());
+ std::unique_ptr<base::SyncSocket> child_pipe(new base::SyncSocket());
if (!base::SyncSocket::CreatePair(local_pipe.get(), child_pipe.get()))
return base::ScopedFD();
{
@@ -59,7 +59,7 @@ void CrashMicroDumpManager::HandleChildTerminationOnFileThread(
base::TerminationStatus termination_status) {
DCHECK_CURRENTLY_ON(BrowserThread::FILE);
- scoped_ptr<base::SyncSocket> pipe;
+ std::unique_ptr<base::SyncSocket> pipe;
{
base::AutoLock auto_lock(child_process_id_to_pipe_lock_);
const auto& iter = child_process_id_to_pipe_.find(child_process_id);
« no previous file with comments | « components/crash/content/browser/crash_micro_dump_manager_android.h ('k') | components/os_crypt/ie7_password_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698