Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1884083002: Revert of Rename Heap to ThreadHeap (Closed)

Created:
4 years, 8 months ago by keishi
Modified:
4 years, 8 months ago
CC:
chromium-reviews, shans, dshwang, eae+blinkwatch, fs, eric.carlson_apple.com, apavlov+blink_chromium.org, kinuko+watch, kouhei+svg_chromium.org, rwlbuis, caseq+blink_chromium.org, krit, Mads Ager (chromium), blink-reviews-css, blink-reviews-html_chromium.org, ajuma+watch-canvas_chromium.org, Justin Novosad, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, blink-reviews, gyuyoung2, pdr+svgwatchlist_chromium.org, Eric Willigers, nessy, rjwright, blink-reviews-style_chromium.org, sof, lushnikov+blink_chromium.org, feature-media-reviews_chromium.org, dcheng, darktears, jsbell+idb_chromium.org, vcarbune.chromium, philipj_slow, mlamouri+watch-blink_chromium.org, blink-reviews-animation_chromium.org, gasubic, pfeldman+blink_chromium.org, f(malita), pfeldman, cmumford, oilpan-reviews, Stephen Chennney, kouhei+heap_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Rename Heap to ThreadHeap (patchset #13 id:240001 of https://codereview.chromium.org/1845543002/ ) Reason for revert: Failed memory_test: content_unittests Original issue's description: > Rename Heap to ThreadHeap > > BUG=591606 > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq > > Committed: https://crrev.com/191c640cc25f76c0c0f8a0b448de33cd059f4a8e > Cr-Commit-Position: refs/heads/master@{#387233} TBR=oilpan-reviews@chromium.org,haraken@chromium.org,peria@chromium.org,caseq@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=591606 Committed: https://crrev.com/b298b9354505c3ded029dadd92675ca3405a6381 Cr-Commit-Position: refs/heads/master@{#387254}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+361 lines, -354 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationStackTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationTimelineTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSStyleSheetResourceTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/StylePropertySet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/MatchedPropertiesCache.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/CrossThreadTaskTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentStatisticsCollectorTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ElementData.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ElementData.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/AutoplayExperimentTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElementRareData.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/csspaint/PaintWorkletTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerTeeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandleTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/LifecycleContextTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/Timer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/Platform.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/BlinkGC.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/GarbageCollected.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/Handle.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.h View 8 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 28 chunks +90 lines, -83 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapAllocator.h View 8 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.cpp View 18 chunks +21 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTerminatedArray.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 38 chunks +76 lines, -76 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/PagePool.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/RunAllTests.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 23 chunks +38 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/RunAllTests.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrame.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebHeap.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/oilpan_gc_times.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/oilpan_gc_times_unittest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
keishi
Created Revert of Rename Heap to ThreadHeap
4 years, 8 months ago (2016-04-14 07:11:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884083002/1
4 years, 8 months ago (2016-04-14 07:11:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 07:12:48 UTC) #3
haraken
LGTM
4 years, 8 months ago (2016-04-14 07:14:09 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 07:14:46 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b298b9354505c3ded029dadd92675ca3405a6381
Cr-Commit-Position: refs/heads/master@{#387254}

Powered by Google App Engine
This is Rietveld 408576698