third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp - Issue 1884083002: Revert of Rename Heap to ThreadHeap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp

Issue 1884083002: Revert of Rename Heap to ThreadHeap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp

diff --git a/third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp b/third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp

index 003ba1fef026cec7a13498d13af9db8fb3d2662a..38565aae5c5587b159a9db86c64219662cd4d904 100644

--- a/third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp

+++ b/third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp

@@ -437,7 +437,7 @@

m_scriptRunner.release();

- ThreadHeap::collectAllGarbage();

+ Heap::collectAllGarbage();

// m_scriptRunner is gone. We need to make sure that ScriptRunner::Task do not access dead object.

EXPECT_CALL(*scriptLoader1, execute()).Times(0);