Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1595)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1883193004: [DevTools] Destroy agents on detach. (Closed)

Created:
4 years, 8 months ago by dgozman
Modified:
4 years, 8 months ago
Reviewers:
caseq, sof, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Destroy agents on detach. This is good in itself and is a step towards multiclient. BUG=590878 Committed: https://crrev.com/cd70a057c54c0b5f70bd2c59e60c78eb1f0cded1 Cr-Commit-Position: refs/heads/master@{#388131}

Patch Set 1 #

Patch Set 2 : cleanup m_state #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -39 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorBaseAgent.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.h View 1 2 3 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp View 4 chunks +21 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 5 chunks +19 lines, -10 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
dgozman
Could you please take a look?
4 years, 8 months ago (2016-04-15 23:57:35 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883193004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883193004/1
4 years, 8 months ago (2016-04-18 17:23:49 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/199295)
4 years, 8 months ago (2016-04-18 18:09:57 UTC) #6
pfeldman
lgtm
4 years, 8 months ago (2016-04-18 22:49:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883193004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883193004/20001
4 years, 8 months ago (2016-04-19 01:58:09 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/161620) ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 8 months ago (2016-04-19 02:00:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883193004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883193004/40001
4 years, 8 months ago (2016-04-19 02:49:28 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-19 03:55:16 UTC) #16
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/cd70a057c54c0b5f70bd2c59e60c78eb1f0cded1 Cr-Commit-Position: refs/heads/master@{#388131}
4 years, 8 months ago (2016-04-19 03:56:55 UTC) #18
sof
It looks like this introduced some leaks, https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/18913
4 years, 8 months ago (2016-04-19 07:34:35 UTC) #20
dgozman
4 years, 8 months ago (2016-04-19 16:59:34 UTC) #21
Message was sent while issue was closed. 
On 2016/04/19 07:34:35, sof wrote:
> It looks like this introduced some leaks,
> 
> 
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/b...

Thanks, I will follow up.

Powered by Google App Engine
This is Rietveld 408576698