Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Unified Diff: third_party/WebKit/Source/core/inspector/WorkerInspectorController.h

Issue 1883193004: [DevTools] Destroy agents on detach. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/WorkerInspectorController.h
diff --git a/third_party/WebKit/Source/core/inspector/WorkerInspectorController.h b/third_party/WebKit/Source/core/inspector/WorkerInspectorController.h
index 6f6325abf0df7501af34cf9ce8965e39ed689b85..f49868239f86d28eb88804695f6b0f61b4a34029 100644
--- a/third_party/WebKit/Source/core/inspector/WorkerInspectorController.h
+++ b/third_party/WebKit/Source/core/inspector/WorkerInspectorController.h
@@ -46,9 +46,8 @@ namespace blink {
class InstrumentingAgents;
class V8Debugger;
class V8InspectorSession;
-class WorkerDebuggerAgent;
class WorkerGlobalScope;
-class WorkerRuntimeAgent;
+class WorkerThreadDebugger;
namespace protocol {
class Dispatcher;
@@ -71,7 +70,10 @@ public:
void dispose();
private:
- WorkerInspectorController(WorkerGlobalScope*, PassOwnPtr<V8InspectorSession>);
+ WorkerInspectorController(WorkerGlobalScope*, WorkerThreadDebugger*);
+
+ void initializeAgents();
+ void destroyAgents();
// InspectorRuntimeAgent::Client implementation.
void resumeStartup() override;
@@ -81,14 +83,13 @@ private:
void sendProtocolNotification(PassOwnPtr<protocol::DictionaryValue> message) override;
void flush() override;
+ WorkerThreadDebugger* m_debugger;
Member<WorkerGlobalScope> m_workerGlobalScope;
Member<InstrumentingAgents> m_instrumentingAgents;
InspectorAgentRegistry m_agents;
OwnPtr<V8InspectorSession> m_v8Session;
OwnPtr<protocol::Frontend> m_frontend;
OwnPtr<protocol::Dispatcher> m_backendDispatcher;
- Member<WorkerDebuggerAgent> m_workerDebuggerAgent;
- Member<WorkerRuntimeAgent> m_workerRuntimeAgent;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698