third_party/WebKit/Source/web/WebDevToolsAgentImpl.h - Issue 1883193004: [DevTools] Destroy agents on detach.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebDevToolsAgentImpl.h

Issue 1883193004: [DevTools] Destroy agents on detach. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebDevToolsAgentImpl.h

diff --git a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h

index e3917c7618c54d0a453020f400b4de59e3c91d25..e2c9d2629afa1076dfda78865fd8d6731dbb6ffd 100644

--- a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h

+++ b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h

@@ -137,7 +137,8 @@ private:

void willProcessTask() override;

void didProcessTask() override;

- void initializeDeferredAgents();

+ void initializeAgents();

+ void destroyAgents();

friend class WebDevToolsAgent;

static void runDebuggerTask(int sessionId, PassOwnPtr<WebDevToolsAgent::MessageDescriptor>);

@@ -165,7 +166,6 @@ private:

OwnPtr<protocol::Dispatcher> m_inspectorBackendDispatcher;

OwnPtr<protocol::Frontend> m_inspectorFrontend;

InspectorAgentRegistry m_agents;

- bool m_deferredAgentsInitialized;

bool m_includeViewAgents;

typedef Vector<std::pair<int, OwnPtr<protocol::Value>>> NotificationQueue;