Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1471)

Side by Side Diff: third_party/WebKit/Source/web/InspectorOverlay.cpp

Issue 1883193004: [DevTools] Destroy agents on detach. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 571 matching lines...) Expand 10 before | Expand all | Expand 10 after
582 if (m_overlayPage) { 582 if (m_overlayPage) {
583 m_overlayPage->willBeDestroyed(); 583 m_overlayPage->willBeDestroyed();
584 m_overlayPage.clear(); 584 m_overlayPage.clear();
585 m_overlayChromeClient.clear(); 585 m_overlayChromeClient.clear();
586 } 586 }
587 m_resizeTimerActive = false; 587 m_resizeTimerActive = false;
588 m_pausedInDebuggerMessage = String(); 588 m_pausedInDebuggerMessage = String();
589 m_inspectMode = InspectorDOMAgent::NotSearching; 589 m_inspectMode = InspectorDOMAgent::NotSearching;
590 m_timer.stop(); 590 m_timer.stop();
591 hideHighlight(); 591 hideHighlight();
592
593 m_debuggerAgent.clear();
594 m_domAgent.clear();
595 m_cssAgent.clear();
596 m_overlayHost->setListener(nullptr);
592 } 597 }
593 598
594 void InspectorOverlay::overlayResumed() 599 void InspectorOverlay::overlayResumed()
595 { 600 {
596 if (m_debuggerAgent) { 601 if (m_debuggerAgent) {
597 ErrorString error; 602 ErrorString error;
598 m_debuggerAgent->resume(&error); 603 m_debuggerAgent->resume(&error);
599 } 604 }
600 } 605 }
601 606
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
774 779
775 void InspectorOverlay::initializeLayoutEditorIfNeeded(Node* node) 780 void InspectorOverlay::initializeLayoutEditorIfNeeded(Node* node)
776 { 781 {
777 if (m_inspectMode != InspectorDOMAgent::ShowLayoutEditor || !node || !node-> isElementNode() || !node->ownerDocument()->isActive()) 782 if (m_inspectMode != InspectorDOMAgent::ShowLayoutEditor || !node || !node-> isElementNode() || !node->ownerDocument()->isActive())
778 return; 783 return;
779 m_layoutEditor = LayoutEditor::create(toElement(node), m_cssAgent, m_domAgen t, &overlayMainFrame()->script()); 784 m_layoutEditor = LayoutEditor::create(toElement(node), m_cssAgent, m_domAgen t, &overlayMainFrame()->script());
780 toChromeClientImpl(m_webViewImpl->page()->chromeClient()).setCursorOverridde n(true); 785 toChromeClientImpl(m_webViewImpl->page()->chromeClient()).setCursorOverridde n(true);
781 } 786 }
782 787
783 } // namespace blink 788 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698