Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 1879613003: Convert //components/dom_distiller from scoped_ptr to std::unique_ptr (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
Reviewers:
nyquist
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert //components/dom_distiller from scoped_ptr to std::unique_ptr BUG=554298 Committed: https://crrev.com/fecbe3fea62c512555c2f9c63b936331c9915619 Cr-Commit-Position: refs/heads/master@{#386851}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+464 lines, -416 lines) Patch
M components/dom_distiller/content/browser/distillable_page_utils_android.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M components/dom_distiller/content/browser/distillable_page_utils_browsertest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M components/dom_distiller/content/browser/distiller_page_web_contents.h View 4 chunks +9 lines, -9 lines 0 comments Download
M components/dom_distiller/content/browser/distiller_page_web_contents.cc View 3 chunks +12 lines, -11 lines 0 comments Download
M components/dom_distiller/content/browser/distiller_page_web_contents_browsertest.cc View 12 chunks +14 lines, -14 lines 0 comments Download
M components/dom_distiller/content/browser/dom_distiller_viewer_source.h View 3 chunks +5 lines, -6 lines 0 comments Download
M components/dom_distiller/content/browser/dom_distiller_viewer_source.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/dom_distiller/content/browser/dom_distiller_viewer_source_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller/core/article_attachments_data.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/dom_distiller/core/article_attachments_data.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/dom_distiller/core/distillable_page_detector.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/dom_distiller/core/distillable_page_detector.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M components/dom_distiller/core/distillable_page_detector_unittest.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M components/dom_distiller/core/distilled_content_store.h View 3 chunks +5 lines, -4 lines 0 comments Download
M components/dom_distiller/core/distilled_content_store.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/dom_distiller/core/distilled_content_store_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M components/dom_distiller/core/distilled_page_prefs_unittests.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/dom_distiller/core/distiller.h View 7 chunks +10 lines, -10 lines 0 comments Download
M components/dom_distiller/core/distiller.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M components/dom_distiller/core/distiller_page.h View 3 chunks +8 lines, -7 lines 0 comments Download
M components/dom_distiller/core/distiller_page.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/dom_distiller/core/distiller_unittest.cc View 25 chunks +40 lines, -43 lines 0 comments Download
M components/dom_distiller/core/distiller_url_fetcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/dom_distiller/core/distiller_url_fetcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/dom_distiller/core/distiller_url_fetcher_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/dom_distiller/core/dom_distiller_request_view_base.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/dom_distiller/core/dom_distiller_request_view_base.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/dom_distiller/core/dom_distiller_request_view_base_unittest.cc View 13 chunks +14 lines, -14 lines 0 comments Download
M components/dom_distiller/core/dom_distiller_service.h View 6 chunks +35 lines, -30 lines 0 comments Download
M components/dom_distiller/core/dom_distiller_service.cc View 5 chunks +22 lines, -20 lines 0 comments Download
M components/dom_distiller/core/dom_distiller_service_unittest.cc View 16 chunks +34 lines, -28 lines 0 comments Download
M components/dom_distiller/core/dom_distiller_store.h View 8 chunks +19 lines, -18 lines 0 comments Download
M components/dom_distiller/core/dom_distiller_store.cc View 9 chunks +15 lines, -14 lines 0 comments Download
M components/dom_distiller/core/dom_distiller_store_unittest.cc View 8 chunks +14 lines, -10 lines 0 comments Download
M components/dom_distiller/core/dom_distiller_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller/core/fake_distiller.h View 3 chunks +8 lines, -6 lines 0 comments Download
M components/dom_distiller/core/fake_distiller.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M components/dom_distiller/core/fake_distiller_page.h View 1 chunk +5 lines, -5 lines 0 comments Download
M components/dom_distiller/core/page_features.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/dom_distiller/core/page_features_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M components/dom_distiller/core/task_tracker.h View 4 chunks +8 lines, -7 lines 0 comments Download
M components/dom_distiller/core/task_tracker.cc View 6 chunks +9 lines, -7 lines 0 comments Download
M components/dom_distiller/core/task_tracker_unittest.cc View 13 chunks +41 lines, -25 lines 0 comments Download
M components/dom_distiller/core/viewer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/dom_distiller/core/viewer.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M components/dom_distiller/core/viewer_unittest.cc View 5 chunks +19 lines, -19 lines 0 comments Download
M components/dom_distiller/ios/distiller_page_factory_ios.h View 2 chunks +5 lines, -4 lines 0 comments Download
M components/dom_distiller/ios/distiller_page_factory_ios.mm View 2 chunks +6 lines, -5 lines 0 comments Download
M components/dom_distiller/ios/distiller_page_ios.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/dom_distiller/ios/distiller_page_ios.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M components/dom_distiller/standalone/content_extractor_browsertest.cc View 1 7 chunks +24 lines, -20 lines 0 comments Download
M components/dom_distiller/webui/dom_distiller_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
dcheng
This is largely a search and replace. There's probably some IWYU errors (files that don't ...
4 years, 8 months ago (2016-04-11 20:25:04 UTC) #2
nyquist
lgtm. Thanks for doing this!
4 years, 8 months ago (2016-04-12 20:12:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1879613003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1879613003/1
4 years, 8 months ago (2016-04-12 21:33:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/158446) ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 8 months ago (2016-04-12 21:37:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1879613003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1879613003/20001
4 years, 8 months ago (2016-04-12 22:11:21 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-12 23:18:18 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 23:19:44 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fecbe3fea62c512555c2f9c63b936331c9915619
Cr-Commit-Position: refs/heads/master@{#386851}

Powered by Google App Engine
This is Rietveld 408576698