components/dom_distiller/core/article_attachments_data.cc - Issue 1879613003: Convert //components/dom_distiller from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/core/article_attachments_data.cc

Issue 1879613003: Convert //components/dom_distiller from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/dom_distiller/core/article_attachments_data.h ('k') | components/dom_distiller/core/distillable_page_detector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/dom_distiller/core/article_attachments_data.cc

diff --git a/components/dom_distiller/core/article_attachments_data.cc b/components/dom_distiller/core/article_attachments_data.cc

index 8174c48cdab391871d439440cf9d64dd735c7ec1..c888c00271bd18d94c531b661430ab7d727c1974 100644

--- a/components/dom_distiller/core/article_attachments_data.cc

+++ b/components/dom_distiller/core/article_attachments_data.cc

@@ -16,10 +16,11 @@ syncer::AttachmentIdList GetAttachmentIds(

return ids;

}

-scoped_ptr<ArticleAttachmentsData> ArticleAttachmentsData::GetFromAttachmentMap(

+std::unique_ptr<ArticleAttachmentsData>

+ArticleAttachmentsData::GetFromAttachmentMap(

const sync_pb::ArticleAttachments& attachments_key,

const syncer::AttachmentMap& attachment_map) {

- scoped_ptr<ArticleAttachmentsData> data(new ArticleAttachmentsData);

+ std::unique_ptr<ArticleAttachmentsData> data(new ArticleAttachmentsData);

syncer::AttachmentMap::const_iterator iter =

attachment_map.find(syncer::AttachmentId::CreateFromProto(

attachments_key.distilled_article()));