components/dom_distiller/ios/distiller_page_ios.mm - Issue 1879613003: Convert //components/dom_distiller from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/ios/distiller_page_ios.mm

Issue 1879613003: Convert //components/dom_distiller from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/dom_distiller/ios/distiller_page_ios.h ('k') | components/dom_distiller/standalone/content_extractor_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/dom_distiller/ios/distiller_page_ios.mm

diff --git a/components/dom_distiller/ios/distiller_page_ios.mm b/components/dom_distiller/ios/distiller_page_ios.mm

index 0009e5bdad0416ad2b6c4947d953dcad4f841c3a..a20326d2b7e9152d4586bf6b66baded77b1e2646 100644

--- a/components/dom_distiller/ios/distiller_page_ios.mm

+++ b/components/dom_distiller/ios/distiller_page_ios.mm

@@ -103,9 +103,9 @@ void DistillerPageIOS::OnLoadURLDone(

}

void DistillerPageIOS::HandleJavaScriptResultString(NSString* result) {

- scoped_ptr<base::Value> resultValue = base::Value::CreateNullValue();

+ std::unique_ptr<base::Value> resultValue = base::Value::CreateNullValue();

if (result.length) {

- scoped_ptr<base::Value> dictionaryValue =

+ std::unique_ptr<base::Value> dictionaryValue =

base::JSONReader::Read(base::SysNSStringToUTF8(result));

if (dictionaryValue &&

dictionaryValue->IsType(base::Value::TYPE_DICTIONARY)) {