components/dom_distiller/ios/distiller_page_ios.h - Issue 1879613003: Convert //components/dom_distiller from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/ios/distiller_page_ios.h

Issue 1879613003: Convert //components/dom_distiller from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/dom_distiller/ios/distiller_page_factory_ios.mm ('k') | components/dom_distiller/ios/distiller_page_ios.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/dom_distiller/ios/distiller_page_ios.h

diff --git a/components/dom_distiller/ios/distiller_page_ios.h b/components/dom_distiller/ios/distiller_page_ios.h

index c9320d10bdd028231b9dade23f96a1affbcb5cf0..2103959a76eebd8bedf1aad77b09aa24361126ee 100644

--- a/components/dom_distiller/ios/distiller_page_ios.h

+++ b/components/dom_distiller/ios/distiller_page_ios.h

@@ -5,9 +5,9 @@

#ifndef COMPONENTS_DOM_DISTILLER_IOS_DISTILLER_PAGE_IOS_H_

#define COMPONENTS_DOM_DISTILLER_IOS_DISTILLER_PAGE_IOS_H_

+#include <memory>

#include <string>

-#include "base/memory/scoped_ptr.h"

#include "base/memory/weak_ptr.h"

#include "components/dom_distiller/core/distiller_page.h"

#include "ios/web/public/web_state/web_state_observer.h"

@@ -49,8 +49,8 @@ class DistillerPageIOS : public DistillerPage {

web::BrowserState* browser_state_;

GURL url_;

std::string script_;

- scoped_ptr<ios::WebControllerProvider> provider_;

- scoped_ptr<DistillerWebStateObserver> web_state_observer_;

+ std::unique_ptr<ios::WebControllerProvider> provider_;

+ std::unique_ptr<DistillerWebStateObserver> web_state_observer_;

base::WeakPtrFactory<DistillerPageIOS> weak_ptr_factory_;

};

« no previous file with comments | « components/dom_distiller/ios/distiller_page_factory_ios.mm ('k') | components/dom_distiller/ios/distiller_page_ios.mm » ('j') | no next file with comments »