Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1879163003: DevTools: cleanup occurences of selection.getRangeAt to avoid NPE (Closed)

Created:
4 years, 8 months ago by lushnikov
Modified:
4 years, 8 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@selection-exception
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: cleanup occurences of selection.getRangeAt to avoid NPE This is a follow-up patch to https://crrev.com/1881233002/ which cleans up the rest of selection.getRangeAt occurences in the front-end. BUG=595100 R=dgozman, pfeldman_ooo Committed: https://crrev.com/03c78a1961eb22e25ed8f2f136a35b6fb8098a2b Cr-Commit-Position: refs/heads/master@{#387199}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
lushnikov
ptal
4 years, 8 months ago (2016-04-12 22:05:28 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1879163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1879163003/1
4 years, 8 months ago (2016-04-12 22:06:09 UTC) #4
dgozman
lgtm
4 years, 8 months ago (2016-04-12 22:29:21 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/196557)
4 years, 8 months ago (2016-04-12 23:03:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1879163003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1879163003/20001
4 years, 8 months ago (2016-04-14 00:08:06 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-14 01:35:51 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 01:37:07 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/03c78a1961eb22e25ed8f2f136a35b6fb8098a2b
Cr-Commit-Position: refs/heads/master@{#387199}

Powered by Google App Engine
This is Rietveld 408576698