third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js - Issue 1879163003: DevTools: cleanup occurences of selection.getRangeAt to avoid NPE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js

Issue 1879163003: DevTools: cleanup occurences of selection.getRangeAt to avoid NPE (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@selection-exception

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js b/third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js

index c8db4dbaefb0a6d5bbb6e0ce33ec7bd8a285c555..7db48ee418bcb46a860b58299d228ad44c51ddc6 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js

@@ -278,7 +278,8 @@ WebInspector.ViewportControl.prototype = {

_updateSelectionModel: function(selection)

{

- if (!selection || !selection.rangeCount || selection.isCollapsed) {

+ var range = selection && selection.rangeCount ? selection.getRangeAt(0) : null;

+ if (!range || selection.isCollapsed) {

this._headSelection = null;

this._anchorSelection = null;

return false;

@@ -287,7 +288,6 @@ WebInspector.ViewportControl.prototype = {

var firstSelected = Number.MAX_VALUE;

var lastSelected = -1;

- var range = selection.getRangeAt(0);

var hasVisibleSelection = false;

for (var i = 0; i < this._renderedItems.length; ++i) {

if (range.intersectsNode(this._renderedItems[i].element())) {

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js ('k') | no next file » | no next file with comments »