third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js - Issue 1879163003: DevTools: cleanup occurences of selection.getRangeAt to avoid NPE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js

Issue 1879163003: DevTools: cleanup occurences of selection.getRangeAt to avoid NPE (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@selection-exception

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js

diff --git a/third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js b/third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js

index 24da159bf954746b9c10e58eff5e6c915686e579..d3c202c0c0eedd3b0b39f3cf6b5895e6be75a827 100644

--- a/third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js

+++ b/third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js

@@ -301,7 +301,8 @@ Node.prototype.isComponentSelectionCollapsed = function()

{

// FIXME: crbug.com/447523, use selection.isCollapsed when it is fixed for shadow dom.

var selection = this.getComponentSelection();

- return selection && selection.rangeCount ? selection.getRangeAt(0).collapsed : true;

+ var range = selection && selection.rangeCount ? selection.getRangeAt(0) : null;

+ return range ? range.collapsed : true;

}

/**

« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js » ('j') | no next file with comments »