third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js - Issue 1879163003: DevTools: cleanup occurences of selection.getRangeAt to avoid NPE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js

Issue 1879163003: DevTools: cleanup occurences of selection.getRangeAt to avoid NPE (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@selection-exception

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js ('k') | third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js b/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js

index 4b7917c1613d328f0a1f99a3bc7ee7fca05644b9..ce58e04b879885d37f0d35f446785dac353412c6 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js

@@ -392,10 +392,10 @@ WebInspector.TextPrompt.prototype = {

{

this.clearAutoComplete(true);

var selection = this._element.getComponentSelection();

- if (!selection.rangeCount)

+ var selectionRange = selection && selection.rangeCount ? selection.getRangeAt(0) : null;

+ if (!selectionRange)

return;

- var selectionRange = selection.getRangeAt(0);

var shouldExit;

if (!force && !this.isCaretAtEndOfPrompt() && !this.isSuggestBoxVisible())

@@ -684,10 +684,10 @@ WebInspector.TextPrompt.prototype = {

isCaretAtEndOfPrompt: function()

{

var selection = this._element.getComponentSelection();

- if (!selection.rangeCount || !selection.isCollapsed)

+ var selectionRange = selection && selection.rangeCount ? selection.getRangeAt(0) : null;

+ if (!selectionRange || !selection.isCollapsed)

return false;

- var selectionRange = selection.getRangeAt(0);

var node = selectionRange.startContainer;

if (!node.isSelfOrDescendant(this._element))

return false;