ash/system/overview/overview_button_tray.cc - Issue 1877543002: Revise the shelf alignment locking mechanism.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/system/overview/overview_button_tray.cc

Issue 1877543002: Revise the shelf alignment locking mechanism. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update and cleanup tests. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/system/overview/overview_button_tray.cc

diff --git a/ash/system/overview/overview_button_tray.cc b/ash/system/overview/overview_button_tray.cc

index e68a193e18ae09bc36b038004c9f4acfb99abf97..eb6dce8866f6b9957f09a399f5dbc0199e9b5ee3 100644

--- a/ash/system/overview/overview_button_tray.cc

+++ b/ash/system/overview/overview_button_tray.cc

@@ -6,6 +6,7 @@

#include "ash/session/session_state_delegate.h"

#include "ash/shelf/shelf_types.h"

+#include "ash/shelf/shelf_util.h"

#include "ash/shell.h"

#include "ash/system/tray/system_tray_delegate.h"

#include "ash/system/tray/tray_utils.h"

@@ -107,7 +108,7 @@ void OverviewButtonTray::SetShelfAlignment(ShelfAlignment alignment) {

}

void OverviewButtonTray::SetIconBorderForShelfAlignment() {

- if (shelf_alignment() == SHELF_ALIGNMENT_BOTTOM) {

+ if (IsHorizontalAlignment(shelf_alignment())) {

icon_->SetBorder(views::Border::CreateEmptyBorder(

kHorizontalShelfVerticalPadding,

kHorizontalShelfHorizontalPadding,

« no previous file with comments | « ash/system/date/tray_date.cc ('k') | ash/system/status_area_widget_delegate.cc » ('j') | no next file with comments »