Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2698)

Unified Diff: ash/wm/window_animations.cc

Issue 1877543002: Revise the shelf alignment locking mechanism. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update and cleanup tests. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/wm/panels/panel_window_resizer.cc ('k') | chrome/browser/ui/ash/chrome_launcher_prefs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/window_animations.cc
diff --git a/ash/wm/window_animations.cc b/ash/wm/window_animations.cc
index a71c7c2ab3cc541ed613946121aa0eaadcf0b1be..58417ecee3034104f30e4ba977c26ff2f4255229 100644
--- a/ash/wm/window_animations.cc
+++ b/ash/wm/window_animations.cc
@@ -468,17 +468,12 @@ gfx::Rect GetMinimizeAnimationTargetBoundsInScreen(aura::Window* window) {
if (item_rect.width() != 0 || item_rect.height() != 0) {
if (shelf->shelf_layout_manager()->visibility_state() == SHELF_AUTO_HIDE) {
gfx::Rect shelf_bounds = shelf->shelf_widget()->GetWindowBoundsInScreen();
- switch (shelf->alignment()) {
- case SHELF_ALIGNMENT_BOTTOM:
- item_rect.set_y(shelf_bounds.y());
- break;
- case SHELF_ALIGNMENT_LEFT:
- item_rect.set_x(shelf_bounds.right());
- break;
- case SHELF_ALIGNMENT_RIGHT:
- item_rect.set_x(shelf_bounds.x());
- break;
- }
+ if (shelf->alignment() == SHELF_ALIGNMENT_LEFT)
+ item_rect.set_x(shelf_bounds.right());
+ else if (shelf->alignment() == SHELF_ALIGNMENT_RIGHT)
+ item_rect.set_x(shelf_bounds.x());
+ else
+ item_rect.set_y(shelf_bounds.y());
return item_rect;
}
}
« no previous file with comments | « ash/wm/panels/panel_window_resizer.cc ('k') | chrome/browser/ui/ash/chrome_launcher_prefs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698