Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1877383002: Only SolidBrush types are created, remove other brushes. (Closed)

Created:
4 years, 8 months ago by dsinclair
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Only SolidBrush types are created, remove other brushes. We only ever create a CFDE_SolidBrush, there is nothing which creates Texture, Hatch or LinearGradient brushes. This Cl removes all the code that isn't used for SolidBrush. A followup Cl will rename SolidBrush to Brush and remove the Brush interface in favour of the concrete class. BUG=pdfium:468 Committed: https://pdfium.googlesource.com/pdfium/+/25c223d1c3a662a0e69a5bf95083afbd5fa3cd97

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1062 lines) Patch
M BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M xfa.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
M xfa/fde/fde_brush.h View 1 2 chunks +1 line, -113 lines 0 comments Download
D xfa/fde/fde_devbasic.h View 1 chunk +0 lines, -20 lines 0 comments Download
D xfa/fde/fde_devbasic.cpp View 1 chunk +0 lines, -550 lines 0 comments Download
M xfa/fde/fde_gedevice.h View 2 chunks +2 lines, -13 lines 0 comments Download
M xfa/fde/fde_gedevice.cpp View 2 chunks +10 lines, -191 lines 0 comments Download
M xfa/fde/fde_object.h View 2 chunks +1 line, -129 lines 0 comments Download
D xfa/fde/fde_object.cpp View 1 chunk +0 lines, -25 lines 0 comments Download
M xfa/fde/fde_pen.h View 2 chunks +1 line, -6 lines 0 comments Download
M xfa/fde/fde_render.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M xfa/fde/tto/fde_textout.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxfa/app/xfa_textlayout.cpp View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dsinclair
PTAL.
4 years, 8 months ago (2016-04-12 15:39:18 UTC) #2
Tom Sepez
lgtm
4 years, 8 months ago (2016-04-12 16:41:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877383002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877383002/20001
4 years, 8 months ago (2016-04-12 16:51:28 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 16:52:01 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/25c223d1c3a662a0e69a5bf95083afbd5fa3...

Powered by Google App Engine
This is Rietveld 408576698