Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1874593002: Mozart: Rename scene graph classes. (Closed)

Created:
4 years, 8 months ago by jeffbrown
Modified:
4 years, 8 months ago
Reviewers:
abarth
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@moz-2
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Mozart: Rename scene graph classes. Removed the confusing *Def suffix on Node and Resource leaving it only on SceneDef. In an earlier design, the Def classes were intended to be mutable representations of client-supplied content. Later it became clear that it was desirable to retain immutable copies of this content instead so that they could be shared by multiple versions. BUG= R=abarth@google.com Committed: https://chromium.googlesource.com/external/mojo/+/36e02d31d33372138630b2d1c168526d37b46f09

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -1240 lines) Patch
M services/gfx/compositor/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
D services/gfx/compositor/graph/node_def.h View 1 chunk +0 lines, -278 lines 0 comments Download
D services/gfx/compositor/graph/node_def.cc View 1 chunk +0 lines, -549 lines 0 comments Download
A + services/gfx/compositor/graph/nodes.h View 10 chunks +61 lines, -61 lines 0 comments Download
A + services/gfx/compositor/graph/nodes.cc View 27 chunks +107 lines, -108 lines 0 comments Download
D services/gfx/compositor/graph/resource_def.h View 1 chunk +0 lines, -91 lines 0 comments Download
D services/gfx/compositor/graph/resource_def.cc View 1 chunk +0 lines, -41 lines 0 comments Download
A + services/gfx/compositor/graph/resources.h View 4 chunks +21 lines, -22 lines 0 comments Download
A services/gfx/compositor/graph/resources.cc View 1 chunk +41 lines, -0 lines 0 comments Download
M services/gfx/compositor/graph/scene_content.h View 4 chunks +13 lines, -13 lines 0 comments Download
M services/gfx/compositor/graph/scene_content.cc View 9 chunks +14 lines, -15 lines 0 comments Download
M services/gfx/compositor/graph/scene_def.h View 5 chunks +13 lines, -13 lines 0 comments Download
M services/gfx/compositor/graph/scene_def.cc View 12 chunks +26 lines, -28 lines 0 comments Download
M services/gfx/compositor/graph/snapshot.h View 5 chunks +9 lines, -9 lines 0 comments Download
M services/gfx/compositor/graph/snapshot.cc View 8 chunks +8 lines, -8 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
jeffbrown
4 years, 8 months ago (2016-04-08 00:22:09 UTC) #2
abarth
lgtm
4 years, 8 months ago (2016-04-08 02:34:39 UTC) #3
jeffbrown
4 years, 8 months ago (2016-04-08 20:36:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
36e02d31d33372138630b2d1c168526d37b46f09 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698