Remove "from all browsers" memory details mode

This mode was only used in chrome://memory, which has been removed, so it's all dead code now, as is ProcessInfoSnapshot.

BUG=599903
Committed: https://crrev.com/cd6e449de2bb5f8c4594ad0bb19225f77c89cea9
Cr-Commit-Position: refs/heads/master@{#387067}

[Elly Fong-Jones, 2016-04-08 14:55:48]

Description was changed from

==========
WIP: remove "from all browsers" memory details mode

BUG=
==========

to

==========
This mode was only used in chrome://memory, which has been removed, so it's all
dead code now.
==========

[Elly Fong-Jones, 2016-04-08 18:44:12]

Description was changed from

==========
This mode was only used in chrome://memory, which has been removed, so it's all
dead code now.
==========

to

==========
This mode was only used in chrome://memory, which has been removed, so it's all
dead code now, as is ProcessInfoSnapshot.
==========

[Elly Fong-Jones, 2016-04-08 18:44:13]

ellyjones@chromium.org changed reviewers:
+ thakis@chromium.org

[Elly Fong-Jones, 2016-04-08 18:45:32]

thakis: ptal? :)

[Nico, 2016-04-08 19:47:45]

lgtm!

bug=599903

https://codereview.chromium.org/1874483002/diff/20001/chrome/browser/memory_d...
File chrome/browser/memory_details.h (right):

https://codereview.chromium.org/1874483002/diff/20001/chrome/browser/memory_d...
chrome/browser/memory_details.h:134: 
(nit: needless new newline)

https://codereview.chromium.org/1874483002/diff/20001/chrome/browser/memory_d...
File chrome/browser/memory_details_linux.cc (right):

https://codereview.chromium.org/1874483002/diff/20001/chrome/browser/memory_d...
chrome/browser/memory_details_linux.cc:173: // it's parent isn't a browser
process, then record it in |browsers_found|.
It kind of feels like there's more than can be simplified here

https://codereview.chromium.org/1874483002/diff/20001/chrome/browser/memory_d...
File chrome/browser/memory_details_win.cc (right):

https://codereview.chromium.org/1874483002/diff/20001/chrome/browser/memory_d...
chrome/browser/memory_details_win.cc:109: for (size_t index2 = 0; index2 <
browser_list_size; ++index2) {
this loop now always runs exactly once

[Alexei Svitkine (slow), 2016-04-08 19:50:27]

asvitkine@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Alexei Svitkine (slow), 2016-04-08 19:50:27]

Sweet, thanks!

Here's a crbug.com that I filed to do this clean up, feel free to associate it
with this cl via BUG=

[Alexei Svitkine (slow), 2016-04-08 19:50:43]

On 2016/04/08 19:50:27, Alexei Svitkine wrote:
> Sweet, thanks!
> 
> Here's a http://crbug.com that I filed to do this clean up, feel free to
associate it
> with this cl via BUG=

http://crbug.com/599903

[Elly Fong-Jones, 2016-04-13 17:18:24]

Hacked a bunch more stuff out. Trying it with the bots now :)

https://codereview.chromium.org/1874483002/diff/20001/chrome/browser/memory_d...
File chrome/browser/memory_details.h (right):

https://codereview.chromium.org/1874483002/diff/20001/chrome/browser/memory_d...
chrome/browser/memory_details.h:134: 
On 2016/04/08 19:47:44, Nico wrote:
> (nit: needless new newline)

Done.

https://codereview.chromium.org/1874483002/diff/20001/chrome/browser/memory_d...
File chrome/browser/memory_details_linux.cc (right):

https://codereview.chromium.org/1874483002/diff/20001/chrome/browser/memory_d...
chrome/browser/memory_details_linux.cc:173: // it's parent isn't a browser
process, then record it in |browsers_found|.
On 2016/04/08 19:47:44, Nico wrote:
> It kind of feels like there's more than can be simplified here

Done.

Because of the way GetBrowserType is implemented, it can never return CHROME, so
this entire loop is dead code now, and Chrome stats are gathered below.
Therefore, browsers_found is always empty, so the loop at the end of this
function is dead. Furthermore, since this is the only use of Process.name, that
field is dead, as is the code to gather it. Also GetBrowserType itself and the
tables it references are now dead. :)

https://codereview.chromium.org/1874483002/diff/20001/chrome/browser/memory_d...
File chrome/browser/memory_details_win.cc (right):

https://codereview.chromium.org/1874483002/diff/20001/chrome/browser/memory_d...
chrome/browser/memory_details_win.cc:109: for (size_t index2 = 0; index2 <
browser_list_size; ++index2) {
On 2016/04/08 19:47:44, Nico wrote:
> this loop now always runs exactly once

I'm scared of this code and it has no tests that I can find, so I hacked a ton
of it out and we'll see if anything breaks.

[Elly Fong-Jones, 2016-04-13 19:08:13]

The CQ bit was checked by ellyjones@chromium.org

[Elly Fong-Jones, 2016-04-13 19:08:14]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1874483002/#ps80001
(title: "Round 2 for windows bots")

[commit-bot: I haz the power, 2016-04-13 19:08:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1874483002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1874483002/80001

[Alexei Svitkine (slow), 2016-04-13 19:14:24]

Description was changed from

==========
This mode was only used in chrome://memory, which has been removed, so it's all
dead code now, as is ProcessInfoSnapshot.
==========

to

==========
This mode was only used in chrome://memory, which has been removed, so it's all
dead code now, as is ProcessInfoSnapshot.

BUG=599903
==========

[Alexei Svitkine (slow), 2016-04-13 19:14:44]

I just edited your CL description to add BUG=599903

[Elly Fong-Jones, 2016-04-13 19:15:17]

On 2016/04/13 19:14:44, Alexei Svitkine wrote:
> I just edited your CL description to add BUG=599903

Ack, sorry, I forgot to do it :)

[Alexei Svitkine (slow), 2016-04-13 19:17:52]

lgtm

https://codereview.chromium.org/1874483002/diff/80001/chrome/browser/memory_d...
File chrome/browser/memory_details_linux.cc (right):

https://codereview.chromium.org/1874483002/diff/80001/chrome/browser/memory_d...
chrome/browser/memory_details_linux.cc:116: std::set<pid_t> browsers_found;
Nit: Remove?

[commit-bot: I haz the power, 2016-04-13 19:32:35]

Description was changed from

==========
This mode was only used in chrome://memory, which has been removed, so it's all
dead code now, as is ProcessInfoSnapshot.

BUG=599903
==========

to

==========
This mode was only used in chrome://memory, which has been removed, so it's all
dead code now, as is ProcessInfoSnapshot.

BUG=599903

Committed: https://crrev.com/cd6e449de2bb5f8c4594ad0bb19225f77c89cea9
Cr-Commit-Position: refs/heads/master@{#387067}
==========

[commit-bot: I haz the power, 2016-04-13 19:32:36]

Patchset 5 (id:??) landed as
https://crrev.com/cd6e449de2bb5f8c4594ad0bb19225f77c89cea9
Cr-Commit-Position: refs/heads/master@{#387067}