Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 1874483002: Remove "from all browsers" memory details mode (Closed)

Created:
4 years, 8 months ago by Elly Fong-Jones
Modified:
4 years, 8 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This mode was only used in chrome://memory, which has been removed, so it's all dead code now, as is ProcessInfoSnapshot. BUG=599903 Committed: https://crrev.com/cd6e449de2bb5f8c4594ad0bb19225f77c89cea9 Cr-Commit-Position: refs/heads/master@{#387067}

Patch Set 1 #

Patch Set 2 : Rip out ProcessInfoSnapshot #

Total comments: 6

Patch Set 3 : Hack out more linux/win code #

Patch Set 4 : Value() -> value() #

Patch Set 5 : Round 2 for windows bots #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -1028 lines) Patch
M chrome/browser/feedback/system_logs/log_sources/memory_details_log_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/memory/oom_memory_details.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/memory_details.h View 1 2 3 chunks +5 lines, -13 lines 0 comments Download
M chrome/browser/memory_details.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/memory_details_android.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/memory_details_linux.cc View 1 2 4 chunks +0 lines, -96 lines 1 comment Download
M chrome/browser/memory_details_mac.cc View 1 2 4 chunks +21 lines, -133 lines 0 comments Download
M chrome/browser/memory_details_win.cc View 1 2 3 4 2 chunks +34 lines, -96 lines 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/metrics_memory_details_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/process_info_snapshot.h View 1 2 1 chunk +0 lines, -116 lines 0 comments Download
D chrome/browser/process_info_snapshot_mac.cc View 1 2 1 chunk +0 lines, -413 lines 0 comments Download
D chrome/browser/process_info_snapshot_mac_unittest.cc View 1 1 chunk +0 lines, -148 lines 0 comments Download
M chrome/browser/site_details_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
Elly Fong-Jones
thakis: ptal? :)
4 years, 8 months ago (2016-04-08 18:45:32 UTC) #4
Nico
lgtm! bug=599903 https://codereview.chromium.org/1874483002/diff/20001/chrome/browser/memory_details.h File chrome/browser/memory_details.h (right): https://codereview.chromium.org/1874483002/diff/20001/chrome/browser/memory_details.h#newcode134 chrome/browser/memory_details.h:134: (nit: needless new newline) https://codereview.chromium.org/1874483002/diff/20001/chrome/browser/memory_details_linux.cc File chrome/browser/memory_details_linux.cc ...
4 years, 8 months ago (2016-04-08 19:47:45 UTC) #5
Alexei Svitkine (slow)
Sweet, thanks! Here's a crbug.com that I filed to do this clean up, feel free ...
4 years, 8 months ago (2016-04-08 19:50:27 UTC) #7
Alexei Svitkine (slow)
On 2016/04/08 19:50:27, Alexei Svitkine wrote: > Sweet, thanks! > > Here's a http://crbug.com that ...
4 years, 8 months ago (2016-04-08 19:50:43 UTC) #8
Elly Fong-Jones
Hacked a bunch more stuff out. Trying it with the bots now :) https://codereview.chromium.org/1874483002/diff/20001/chrome/browser/memory_details.h File ...
4 years, 8 months ago (2016-04-13 17:18:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1874483002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1874483002/80001
4 years, 8 months ago (2016-04-13 19:08:35 UTC) #12
Alexei Svitkine (slow)
I just edited your CL description to add BUG=599903
4 years, 8 months ago (2016-04-13 19:14:44 UTC) #14
Elly Fong-Jones
On 2016/04/13 19:14:44, Alexei Svitkine wrote: > I just edited your CL description to add ...
4 years, 8 months ago (2016-04-13 19:15:17 UTC) #15
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/1874483002/diff/80001/chrome/browser/memory_details_linux.cc File chrome/browser/memory_details_linux.cc (right): https://codereview.chromium.org/1874483002/diff/80001/chrome/browser/memory_details_linux.cc#newcode116 chrome/browser/memory_details_linux.cc:116: std::set<pid_t> browsers_found; Nit: Remove?
4 years, 8 months ago (2016-04-13 19:17:52 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 19:32:36 UTC) #18
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/cd6e449de2bb5f8c4594ad0bb19225f77c89cea9
Cr-Commit-Position: refs/heads/master@{#387067}

Powered by Google App Engine
This is Rietveld 408576698