Remove "from all browsers" memory details mode

chrome/browser/memory_details_linux.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/memory_details.h"
 
 #include <stddef.h>
 #include <sys/types.h>
 #include <unistd.h>
 
@@ skipping 145 matching lines @@
 }  // namespace
 
 MemoryDetails::MemoryDetails() {
 }
 
 ProcessData* MemoryDetails::ChromeBrowser() {
   return &process_data_[0];
 }
 
 void MemoryDetails::CollectProcessData(
-    CollectionMode mode,
     const std::vector<ProcessMemoryInformation>& child_info) {
   DCHECK(BrowserThread::GetBlockingPool()->RunsTasksOnCurrentThread());
 
   ProcessMap process_map = GetProcesses();
   std::set<pid_t> browsers_found;
 
   // For each process on the system, if it appears to be a browser process and
   // it's parent isn't a browser process, then record it in |browsers_found|.

[Nico, 2016/04/08 19:47:44]

It kind of feels like there's more than can be simplified here

[Elly Fong-Jones, 2016/04/13 17:18:24]

Done.

Because of the way GetBrowserType is implemented, it can never return CHROME, so
this entire loop is dead code now, and Chrome stats are gathered below.
Therefore, browsers_found is always empty, so the loop at the end of this
function is dead. Furthermore, since this is the only use of Process.name, that
field is dead, as is the code to gather it. Also GetBrowserType itself and the
tables it references are now dead. :)

   for (const auto& entry : process_map) {
     const Process& current_process = entry.second;
     const BrowserType type = GetBrowserType(current_process.name);
     if (type == MAX_BROWSERS)
       continue;
-    if (type != CHROME && mode == FROM_CHROME_ONLY)
+    if (type != CHROME)
       continue;
 
     ProcessMap::const_iterator parent_iter =
         process_map.find(current_process.parent);
     if (parent_iter == process_map.end()) {
       browsers_found.insert(current_process.pid);
       continue;
     }
 
     if (GetBrowserType(parent_iter->second.name) != type) {
@@ skipping 42 matching lines @@
 
 #if defined(OS_CHROMEOS)
   base::GetSwapInfo(&swap_info_);
 #endif
 
   // Finally return to the browser thread.
   BrowserThread::PostTask(
       BrowserThread::UI, FROM_HERE,
       base::Bind(&MemoryDetails::CollectChildInfoOnUIThread, this));
 }