Remove "from all browsers" memory details mode

chrome/browser/memory_details_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/memory_details.h"
 
 #include <psapi.h>
 #include <stddef.h>
 #include <TlHelp32.h>
 
@@ skipping 55 matching lines @@
     process.process_name = process_template[index].process_name;
     process_data_.push_back(process);
   }
 }
 
 ProcessData* MemoryDetails::ChromeBrowser() {
   return &process_data_[CHROME_BROWSER];
 }
 
 void MemoryDetails::CollectProcessData(
-    CollectionMode mode,
     const std::vector<ProcessMemoryInformation>& child_info) {
   DCHECK(BrowserThread::GetBlockingPool()->RunsTasksOnCurrentThread());
 
   // Clear old data.
   for (unsigned int index = 0; index < process_data_.size(); index++)
     process_data_[index].processes.clear();
 
   base::win::OSInfo::WindowsArchitecture windows_architecture =
       base::win::OSInfo::GetInstance()->architecture();
 
@@ skipping 12 matching lines @@
     base::ProcessId pid = process_entry.th32ProcessID;
     base::win::ScopedHandle process_handle(::OpenProcess(
         PROCESS_QUERY_INFORMATION | PROCESS_VM_READ, FALSE, pid));
     if (!process_handle.IsValid())
       continue;
     bool is_64bit_process =
         ((windows_architecture == base::win::OSInfo::X64_ARCHITECTURE) ||
          (windows_architecture == base::win::OSInfo::IA64_ARCHITECTURE)) &&
         (base::win::OSInfo::GetWOW64StatusForProcess(process_handle.Get()) ==
             base::win::OSInfo::WOW64_DISABLED);
-    const size_t browser_list_size =
-        (mode == FROM_CHROME_ONLY ? 1 : process_data_.size());
+    const size_t browser_list_size = 1;
     for (size_t index2 = 0; index2 < browser_list_size; ++index2) {

[Nico, 2016/04/08 19:47:44]

this loop now always runs exactly once

[Elly Fong-Jones, 2016/04/13 17:18:24]

I'm scared of this code and it has no tests that I can find, so I hacked a ton
of it out and we'll see if anything breaks.

       if (_wcsicmp(process_data_[index2].process_name.c_str(),
                    process_entry.szExeFile) != 0)
         continue;
       if (index2 == IE_BROWSER && is_64bit_process)
         continue;  // Should use IE_64BIT_BROWSER
       // Get Memory Information.
       ProcessMemoryInformation info;
       info.pid = pid;
       if (info.pid == GetCurrentProcessId())
         info.process_type = content::PROCESS_TYPE_BROWSER;
@@ skipping 39 matching lines @@
       }
       break;
     }
   } while (::Process32Next(snapshot.Get(), &process_entry));
 
   // Finally return to the browser thread.
   BrowserThread::PostTask(
       BrowserThread::UI, FROM_HERE,
       base::Bind(&MemoryDetails::CollectChildInfoOnUIThread, this));
 }