Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Unified Diff: chrome/browser/memory_details.cc

Issue 1874483002: Remove "from all browsers" memory details mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Round 2 for windows bots Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/memory_details.cc
diff --git a/chrome/browser/memory_details.cc b/chrome/browser/memory_details.cc
index 9cfce48f82bb61cc135ff55a5bf93305c6f65ec2..24479bdb4875db5dcd50f197c08f48e2813d54a7 100644
--- a/chrome/browser/memory_details.cc
+++ b/chrome/browser/memory_details.cc
@@ -133,7 +133,7 @@ ProcessData& ProcessData::operator=(const ProcessData& rhs) {
// one task run for that long on the UI or IO threads. So, we run the
// expensive parts of this operation over on the blocking pool.
//
-void MemoryDetails::StartFetch(CollectionMode mode) {
+void MemoryDetails::StartFetch() {
// This might get called from the UI or FILE threads, but should not be
// getting called from the IO thread.
DCHECK(!BrowserThread::CurrentlyOn(BrowserThread::IO));
@@ -142,7 +142,7 @@ void MemoryDetails::StartFetch(CollectionMode mode) {
// However, plugin process information is only available from the IO thread.
BrowserThread::PostTask(
BrowserThread::IO, FROM_HERE,
- base::Bind(&MemoryDetails::CollectChildInfoOnIOThread, this, mode));
+ base::Bind(&MemoryDetails::CollectChildInfoOnIOThread, this));
}
MemoryDetails::~MemoryDetails() {}
@@ -183,7 +183,7 @@ std::string MemoryDetails::ToLogString() {
return log;
}
-void MemoryDetails::CollectChildInfoOnIOThread(CollectionMode mode) {
+void MemoryDetails::CollectChildInfoOnIOThread() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
std::vector<ProcessMemoryInformation> child_info;
@@ -207,7 +207,7 @@ void MemoryDetails::CollectChildInfoOnIOThread(CollectionMode mode) {
// Now go do expensive memory lookups on the blocking pool.
BrowserThread::GetBlockingPool()->PostWorkerTaskWithShutdownBehavior(
FROM_HERE,
- base::Bind(&MemoryDetails::CollectProcessData, this, mode, child_info),
+ base::Bind(&MemoryDetails::CollectProcessData, this, child_info),
base::SequencedWorkerPool::CONTINUE_ON_SHUTDOWN);
}

Powered by Google App Engine
This is Rietveld 408576698