Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 187443008: Elim Browser::AppType (Closed)

Created:
6 years, 9 months ago by stevenjb
Modified:
6 years, 8 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, tfarina, marja+watch_chromium.org, kalyank, chromium-apps-reviews_chromium.org, ben+ash_chromium.org
Visibility:
Public.

Description

Elim Browser::AppType This CL introduces Browser::Type::TYPE_TRUSTED_POPUP to replace Browser::AppType::APP_TYPE_HOST for identifying app popup windows and system windows (for settings, history, etc). BUG=342983, 359815

Patch Set 1 #

Patch Set 2 : Merge into Type #

Patch Set 3 : rebase #

Total comments: 2

Patch Set 4 : Rebase, rename #

Patch Set 5 : Rebase and add non trusted type test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -97 lines) Patch
M chrome/browser/extensions/api/tabs/tabs_api.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_restore.cc View 1 2 3 1 chunk +10 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/accelerator_commands_browsertest.cc View 1 2 3 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.h View 1 2 3 4 6 chunks +17 lines, -24 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 5 chunks +10 lines, -16 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 2 3 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/browser_navigator.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 1 2 3 5 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.h View 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.cc View 1 2 3 4 5 chunks +23 lines, -8 lines 0 comments Download
M chrome/browser/ui/browser_tab_restore_service_delegate.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/chrome_pages.h View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/chrome_pages.cc View 1 2 3 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/browser/ui/extensions/application_launch.cc View 1 2 3 1 chunk +10 lines, -7 lines 0 comments Download
M chrome/browser/ui/settings_window_manager.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.cc View 1 2 3 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
https://codereview.chromium.org/187443008/diff/30001/chrome/browser/ui/browser.h File chrome/browser/ui/browser.h (right): https://codereview.chromium.org/187443008/diff/30001/chrome/browser/ui/browser.h#newcode116 chrome/browser/ui/browser.h:116: TYPE_HOSTED_POPUP = 3 // A popup window for a ...
6 years, 9 months ago (2014-03-19 17:30:19 UTC) #1
stevenjb
https://codereview.chromium.org/187443008/diff/30001/chrome/browser/ui/browser.h File chrome/browser/ui/browser.h (right): https://codereview.chromium.org/187443008/diff/30001/chrome/browser/ui/browser.h#newcode116 chrome/browser/ui/browser.h:116: TYPE_HOSTED_POPUP = 3 // A popup window for a ...
6 years, 8 months ago (2014-04-04 00:04:09 UTC) #2
stevenjb
6 years, 8 months ago (2014-04-07 21:54:17 UTC) #3 
Today I looked more closely at the ramifications of adding another Type to
SessoinService/Restore and session sync, and I am currently convinced that this
is not the best path.

I am going to try again with Browser::Type unchanged. Stay tuned.

Powered by Google App Engine
This is Rietveld 408576698