Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: chrome/test/base/browser_with_test_window_test.cc

Issue 187443008: Elim Browser::AppType (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase and add non trusted type test Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/frame/browser_view.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/browser_with_test_window_test.cc
diff --git a/chrome/test/base/browser_with_test_window_test.cc b/chrome/test/base/browser_with_test_window_test.cc
index 47d682b1c61776ee143c52191daab8c5fd8b0d49..819ec6c53604f45b80d61365a9617ad4141ff118 100644
--- a/chrome/test/base/browser_with_test_window_test.cc
+++ b/chrome/test/base/browser_with_test_window_test.cc
@@ -226,10 +226,16 @@ Browser* BrowserWithTestWindowTest::CreateBrowser(
chrome::HostDesktopType host_desktop_type,
BrowserWindow* browser_window) {
Browser::CreateParams params(profile, host_desktop_type);
- params.type = browser_type;
+ if (hosted_app) {
+ params = Browser::CreateParams::CreateForApp(Browser::TYPE_TRUSTED_POPUP,
+ "Test",
+ gfx::Rect(),
+ profile,
+ host_desktop_type);
+ } else {
+ params.type = browser_type;
+ }
params.window = browser_window;
- if (hosted_app)
- params.app_name = "Test";
return new Browser(params);
}
« no previous file with comments | « chrome/browser/ui/views/frame/browser_view.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698