Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6273)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 187443008: Elim Browser::AppType (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase and add non trusted type test Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/settings_window_manager.cc ('k') | chrome/test/base/browser_with_test_window_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index 73afdb6d55eae939f163d967f6f4a384af8db86c..df137729f4d2e9f108333f9d51b3e23e12d98f08 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -1578,7 +1578,8 @@ bool BrowserView::ShouldShowWindowTitle() const {
// For Ash only, app host windows do not show an icon, crbug.com/119411.
// Child windows (i.e. popups) do show an icon.
if (browser_->host_desktop_type() == chrome::HOST_DESKTOP_TYPE_ASH &&
- browser_->is_app() && browser_->app_type() == Browser::APP_TYPE_HOST)
+ browser_->is_app() &&
+ browser_->type() == Browser::TYPE_TRUSTED_POPUP)
return false;
return browser_->SupportsWindowFeature(Browser::FEATURE_TITLEBAR);
@@ -1607,7 +1608,8 @@ bool BrowserView::ShouldShowWindowIcon() const {
// For Ash only, app host windows do not show an icon, crbug.com/119411.
// Child windows (i.e. popups) do show an icon.
if (browser_->host_desktop_type() == chrome::HOST_DESKTOP_TYPE_ASH &&
- browser_->is_app() && browser_->app_type() == Browser::APP_TYPE_HOST)
+ browser_->is_app() &&
+ browser_->type() == Browser::TYPE_TRUSTED_POPUP)
return false;
return browser_->SupportsWindowFeature(Browser::FEATURE_TITLEBAR);
« no previous file with comments | « chrome/browser/ui/settings_window_manager.cc ('k') | chrome/test/base/browser_with_test_window_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698