Implement an API to allow passing an "ap" parameter to component updates.

Implement an API to allow passing an "ap" parameter to component updates.

BUG=599703
Committed: https://crrev.com/2b864bc7fba289371958cfb669c4f3ddaf1183e5
Cr-Commit-Position: refs/heads/master@{#386225}

[Sorin Jianu, 2016-04-08 20:45:45]

The CQ bit was checked by sorin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-08 20:46:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1872053002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1872053002/1

[Sorin Jianu, 2016-04-08 20:59:23]

Description was changed from

==========
Implement an API to allow passing an "ap" parameter to component updates.

BUG=599703
==========

to

==========
Implement an API to allow passing an "ap" parameter to component updates.

BUG=599703
==========

[Sorin Jianu, 2016-04-08 20:59:23]

sorin@chromium.org changed reviewers:
+ waffles@chromium.org

[Sorin Jianu, 2016-04-08 20:59:37]

PTAL! Thank you!

[waffles, 2016-04-08 21:06:17]

lgtm

https://codereview.chromium.org/1872053002/diff/20001/components/update_clien...
File components/update_client/update_client.h (right):

https://codereview.chromium.org/1872053002/diff/20001/components/update_clien...
components/update_client/update_client.h:199: std::string ap;           //
Optional. Must match ^([-+_=a-zA-Z0-9]{0,256})$
Nit: No need for ()s.

https://codereview.chromium.org/1872053002/diff/20001/components/update_clien...
File components/update_client/utils.h (right):

https://codereview.chromium.org/1872053002/diff/20001/components/update_clien...
components/update_client/utils.h:102: // Returns true if the |ap| parameter
matches ^([-+_=a-zA-Z0-9]{0,256})$ .
Nit: no need for parens.

https://codereview.chromium.org/1872053002/diff/20001/components/update_clien...
File components/update_client/utils_unittest.cc (right):

https://codereview.chromium.org/1872053002/diff/20001/components/update_clien...
components/update_client/utils_unittest.cc:103:
EXPECT_FALSE(IsValidAp(std::string("\xaa")));    // Has non-ASCII char.
Please add a test for " and \ as well.

[Sorin Jianu, 2016-04-08 21:13:42]

https://codereview.chromium.org/1872053002/diff/20001/components/update_clien...
File components/update_client/update_client.h (right):

https://codereview.chromium.org/1872053002/diff/20001/components/update_clien...
components/update_client/update_client.h:199: std::string ap;           //
Optional. Must match ^([-+_=a-zA-Z0-9]{0,256})$
On 2016/04/08 21:06:16, waffles wrote:
> Nit: No need for ()s.

Done.

https://codereview.chromium.org/1872053002/diff/20001/components/update_clien...
File components/update_client/utils.h (right):

https://codereview.chromium.org/1872053002/diff/20001/components/update_clien...
components/update_client/utils.h:102: // Returns true if the |ap| parameter
matches ^([-+_=a-zA-Z0-9]{0,256})$ .
On 2016/04/08 21:06:16, waffles wrote:
> Nit: no need for parens.

Done.

https://codereview.chromium.org/1872053002/diff/20001/components/update_clien...
File components/update_client/utils_unittest.cc (right):

https://codereview.chromium.org/1872053002/diff/20001/components/update_clien...
components/update_client/utils_unittest.cc:103:
EXPECT_FALSE(IsValidAp(std::string("\xaa")));    // Has non-ASCII char.
On 2016/04/08 21:06:16, waffles wrote:
> Please add a test for " and \ as well.

Done.

[Sorin Jianu, 2016-04-08 21:14:18]

The CQ bit was checked by sorin@chromium.org

[Sorin Jianu, 2016-04-08 21:14:18]

The patchset sent to the CQ was uploaded after l-g-t-m from waffles@chromium.org
Link to the patchset: https://codereview.chromium.org/1872053002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-04-08 21:14:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1872053002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1872053002/40001

[commit-bot: I haz the power, 2016-04-08 22:14:55]

Description was changed from

==========
Implement an API to allow passing an "ap" parameter to component updates.

BUG=599703
==========

to

==========
Implement an API to allow passing an "ap" parameter to component updates.

BUG=599703
==========

[commit-bot: I haz the power, 2016-04-08 22:14:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-08 22:17:15]

Description was changed from

==========
Implement an API to allow passing an "ap" parameter to component updates.

BUG=599703
==========

to

==========
Implement an API to allow passing an "ap" parameter to component updates.

BUG=599703

Committed: https://crrev.com/2b864bc7fba289371958cfb669c4f3ddaf1183e5
Cr-Commit-Position: refs/heads/master@{#386225}
==========

[commit-bot: I haz the power, 2016-04-08 22:17:16]

Patchset 3 (id:??) landed as
https://crrev.com/2b864bc7fba289371958cfb669c4f3ddaf1183e5
Cr-Commit-Position: refs/heads/master@{#386225}