Implement an API to allow passing an "ap" parameter to component updates.

components/update_client/utils_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/file_path.h"
 #include "base/path_service.h"
 #include "components/update_client/utils.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 
@@ skipping 63 matching lines @@
   EXPECT_FALSE(IsValidBrand(std::string("TESTS")));  // Too long.
   EXPECT_FALSE(IsValidBrand(std::string("TES1")));   // Has digit.
   EXPECT_FALSE(IsValidBrand(std::string(" TES")));   // Begins with white space.
   EXPECT_FALSE(IsValidBrand(std::string("TES ")));   // Ends with white space.
   EXPECT_FALSE(IsValidBrand(std::string("T ES")));   // Contains white space.
   EXPECT_FALSE(IsValidBrand(std::string("<TE")));    // Has <.
   EXPECT_FALSE(IsValidBrand(std::string("TE>")));    // Has >.
   EXPECT_FALSE(IsValidBrand(std::string("\xaa")));   // Has non-ASCII char.
 }
 
+// Tests that the ap matches ^([-+_=a-zA-Z0-9]{0,256})$
+TEST(UpdateClientUtils, IsValidAp) {
+  EXPECT_TRUE(IsValidAp(std::string("a=1")));
+  EXPECT_TRUE(IsValidAp(std::string("")));
+  EXPECT_TRUE(IsValidAp(std::string("A")));
+  EXPECT_TRUE(IsValidAp(std::string("Z")));
+  EXPECT_TRUE(IsValidAp(std::string("a")));
+  EXPECT_TRUE(IsValidAp(std::string("z")));
+  EXPECT_TRUE(IsValidAp(std::string("0")));
+  EXPECT_TRUE(IsValidAp(std::string("9")));
+  EXPECT_TRUE(IsValidAp(std::string(256, 'a')));
+  EXPECT_TRUE(IsValidAp(std::string("-+_=")));
+
+  EXPECT_FALSE(IsValidAp(std::string(257, 'a')));  // Too long.
+  EXPECT_FALSE(IsValidAp(std::string(" ap")));     // Begins with white space.
+  EXPECT_FALSE(IsValidAp(std::string("ap ")));     // Ends with white space.
+  EXPECT_FALSE(IsValidAp(std::string("a p")));     // Contains white space.
+  EXPECT_FALSE(IsValidAp(std::string("<ap")));     // Has <.
+  EXPECT_FALSE(IsValidAp(std::string("ap>")));     // Has >.
+  EXPECT_FALSE(IsValidAp(std::string("\xaa")));    // Has non-ASCII char.

[waffles, 2016/04/08 21:06:16]

Please add a test for " and \ as well.

[Sorin Jianu, 2016/04/08 21:13:42]

Done.

+}
+
 TEST(UpdateClientUtils, RemoveUnsecureUrls) {
   const GURL test1[] = {GURL("http://foo"), GURL("https://foo")};
   std::vector<GURL> urls(std::begin(test1), std::end(test1));
   RemoveUnsecureUrls(&urls);
   EXPECT_EQ(1u, urls.size());
   EXPECT_EQ(urls[0], GURL("https://foo"));
 
   const GURL test2[] = {GURL("https://foo"), GURL("http://foo")};
   urls.assign(std::begin(test2), std::end(test2));
   RemoveUnsecureUrls(&urls);
@@ skipping 12 matching lines @@
   RemoveUnsecureUrls(&urls);
   EXPECT_EQ(0u, urls.size());
 
   const GURL test5[] = {GURL("http://foo"), GURL("http://bar")};
   urls.assign(std::begin(test5), std::end(test5));
   RemoveUnsecureUrls(&urls);
   EXPECT_EQ(0u, urls.size());
 }
 
 }  // namespace update_client