Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1842703004: Revert "MD user manager (learn more page, user manager tutorial)" (Closed)

Created:
4 years, 8 months ago by Sorin Jianu
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews, michaelpg+watch-md-ui_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org, jlklein+watch-closure_chromium.org, Dan Beam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "MD user manager (learn more page, user manager tutorial)" This reverts commit e99ec407569d40709ee036fd218e174ccdced70e. It breaks the browser tests on all platforms due to: [3820:5896:0329/153506:WARNING:histogram_base.cc(131)] 2 histograms were created before reporting was enabled. [5572:3816:0329/153506:FATAL:l10n_util.cc(704)] Check failed: std::string::npos == pos (4294967295 vs. 559) Unexpectedly found a $2 placeholder in A supervised user can explore the web with your guidance. As the manager of a supervised user in Chrome, you can: ???allow or prohibit certain websites, ???review websites the supervised user has visited, and ???manage other settings. Creating a supervised user does not create a Google Account, and their bookmarks, browsing history, and other preferences will not follow them to other devices with Chrome Sync. After you create a new supervised user, you can manage their settings at any time, from any device, at <a target="_blank" href="$1">$2</a>. For more information, visit our <a target="_blank" href="https://support.google.com/chrome/?p=ui_supervised_users&hl=en">Help Center</a>. BUG=563722 NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true TBR=mahmadi@chromium.org Committed: https://crrev.com/85912c6be1b9f03fbc305eb560c3f76e0bf3b8d7 Cr-Commit-Position: refs/heads/master@{#383864}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -790 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +1 line, -8 lines 0 comments Download
M chrome/browser/resources/md_user_manager/compiled_resources2.gyp View 2 chunks +2 lines, -15 lines 0 comments Download
M chrome/browser/resources/md_user_manager/control_bar.html View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_user_manager/control_bar.js View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_user_manager/create_profile.html View 4 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/resources/md_user_manager/create_profile.js View 2 chunks +4 lines, -5 lines 0 comments Download
D chrome/browser/resources/md_user_manager/shared_styles.html View 1 chunk +0 lines, -10 lines 0 comments Download
D chrome/browser/resources/md_user_manager/supervised_user_learn_more.css View 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/browser/resources/md_user_manager/supervised_user_learn_more.html View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/browser/resources/md_user_manager/supervised_user_learn_more.js View 1 chunk +0 lines, -22 lines 0 comments Download
A + chrome/browser/resources/md_user_manager/user_manager.css View 4 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/resources/md_user_manager/user_manager.html View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/resources/md_user_manager/user_manager.js View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/md_user_manager/user_manager_pages.css View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/resources/md_user_manager/user_manager_pages.html View 2 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/resources/md_user_manager/user_manager_pages.js View 1 chunk +2 lines, -0 lines 0 comments Download
D chrome/browser/resources/md_user_manager/user_manager_styles.html View 1 chunk +0 lines, -211 lines 0 comments Download
D chrome/browser/resources/md_user_manager/user_manager_tutorial.css View 1 chunk +0 lines, -160 lines 0 comments Download
D chrome/browser/resources/md_user_manager/user_manager_tutorial.html View 1 chunk +0 lines, -96 lines 0 comments Download
D chrome/browser/resources/md_user_manager/user_manager_tutorial.js View 1 chunk +0 lines, -118 lines 0 comments Download
M chrome/browser/ui/webui/signin/md_user_manager_ui.cc View 2 chunks +1 line, -16 lines 0 comments Download
M chrome/browser/ui/webui/signin/signin_create_profile_handler.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842703004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842703004/1
4 years, 8 months ago (2016-03-29 23:37:25 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 23:38:12 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 23:39:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/85912c6be1b9f03fbc305eb560c3f76e0bf3b8d7
Cr-Commit-Position: refs/heads/master@{#383864}

Powered by Google App Engine
This is Rietveld 408576698