Component updater must enforce that the brand length is 4.

Component updater must enforce that the brand length is 4.

BUG=601879
Committed: https://crrev.com/af402ee655981ab3690c6cc00de0a8f3e5071b31
Cr-Commit-Position: refs/heads/master@{#386266}

[Sorin Jianu, 2016-04-08 21:57:31]

Description was changed from

==========
Component updater must enforce that the brand length is 4.

BUG=601879
==========

to

==========
Component updater must enforce that the brand length is 4.

BUG=601879
==========

[Sorin Jianu, 2016-04-08 21:57:31]

sorin@chromium.org changed reviewers:
+ waffles@chromium.org

[Sorin Jianu, 2016-04-08 21:58:04]

Can you please take a look? Thank you!

[Sorin Jianu, 2016-04-08 21:58:19]

The CQ bit was checked by sorin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-08 21:58:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1876573002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1876573002/1

[waffles, 2016-04-08 22:03:49]

lgtm

https://codereview.chromium.org/1876573002/diff/1/components/update_client/ut...
File components/update_client/utils_unittest.cc (right):

https://codereview.chromium.org/1876573002/diff/1/components/update_client/ut...
components/update_client/utils_unittest.cc:79:
EXPECT_FALSE(IsValidAp(std::string("\\")));        // Has backspace.
nit: backspace → backslash

[Sorin Jianu, 2016-04-08 22:56:26]

The CQ bit was unchecked by sorin@chromium.org

[Sorin Jianu, 2016-04-08 22:56:32]

The CQ bit was checked by sorin@chromium.org

[commit-bot: I haz the power, 2016-04-08 22:56:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1876573002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1876573002/1

[Sorin Jianu, 2016-04-08 22:56:48]

The CQ bit was unchecked by sorin@chromium.org

[Sorin Jianu, 2016-04-08 22:58:12]

The CQ bit was checked by sorin@chromium.org

[Sorin Jianu, 2016-04-08 22:58:12]

The patchset sent to the CQ was uploaded after l-g-t-m from waffles@chromium.org
Link to the patchset: https://codereview.chromium.org/1876573002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-04-08 22:58:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1876573002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1876573002/20001

[commit-bot: I haz the power, 2016-04-09 00:06:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-09 00:06:40]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sorin Jianu, 2016-04-09 00:28:10]

The CQ bit was checked by sorin@chromium.org

[Sorin Jianu, 2016-04-09 00:28:17]

https://codereview.chromium.org/1876573002/diff/1/components/update_client/ut...
File components/update_client/utils_unittest.cc (right):

https://codereview.chromium.org/1876573002/diff/1/components/update_client/ut...
components/update_client/utils_unittest.cc:79:
EXPECT_FALSE(IsValidAp(std::string("\\")));        // Has backspace.
On 2016/04/08 22:03:49, waffles wrote:
> nit: backspace → backslash

Done.

[commit-bot: I haz the power, 2016-04-09 00:28:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1876573002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1876573002/20001

[commit-bot: I haz the power, 2016-04-09 01:02:18]

Description was changed from

==========
Component updater must enforce that the brand length is 4.

BUG=601879
==========

to

==========
Component updater must enforce that the brand length is 4.

BUG=601879
==========

[commit-bot: I haz the power, 2016-04-09 01:02:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-09 01:04:02]

Description was changed from

==========
Component updater must enforce that the brand length is 4.

BUG=601879
==========

to

==========
Component updater must enforce that the brand length is 4.

BUG=601879

Committed: https://crrev.com/af402ee655981ab3690c6cc00de0a8f3e5071b31
Cr-Commit-Position: refs/heads/master@{#386266}
==========

[commit-bot: I haz the power, 2016-04-09 01:04:03]

Patchset 2 (id:??) landed as
https://crrev.com/af402ee655981ab3690c6cc00de0a8f3e5071b31
Cr-Commit-Position: refs/heads/master@{#386266}