Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1870853003: Vulcanize settings (hacky and dirty, don't use) (Closed)

Created:
4 years, 8 months ago by michaelpg
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Vulcanize settings (hacky and dirty, don't use) Run with ./chrome/browser/resources/settings/vulcanize.py linux then build normally (use_vulcanize defaults to true) COMMIT=false CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : git squash commit. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -74 lines) Patch
M chrome/browser/PRESUBMIT.py View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
D chrome/browser/resources/md_downloads/vulcanize_readme.md View 1 2 1 chunk +0 lines, -54 lines 0 comments Download
A chrome/browser/resources/settings/flatten_settings.py View 1 2 1 chunk +131 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings.html View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/settings_menu/settings_menu.js View 1 2 1 chunk +3 lines, -1 line 0 comments Download
A chrome/browser/resources/settings/vulcanize.py View 1 2 1 chunk +102 lines, -0 lines 1 comment Download
A + chrome/browser/resources/vulcanize.py View 1 2 1 chunk +2 lines, -6 lines 0 comments Download
A + chrome/browser/resources/vulcanize_readme.md View 1 2 3 chunks +12 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_ui.cc View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/reproduce.sh View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M tools/copyright_scanner/third_party_files_whitelist.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (5 generated)
michaelpg
4 years, 5 months ago (2016-07-01 18:17:24 UTC) #2
Message was sent while issue was closed. 
https://codereview.chromium.org/1870853003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/vulcanize.py (right):

https://codereview.chromium.org/1870853003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/vulcanize.py:1: #!/usr/bin/env python
note: also need to edit vulcanize:

$NODE_INSTALLATION/lib/node_modules/vulcanize/lib/constants.js 

replace the URL_TEMPLATE line with:

  URL_TEMPLATE: '{{.*}}|\\[\\[.*\\]\\]|\\$i18n[^{]*{[^}]*}',

Powered by Google App Engine
This is Rietveld 408576698