chrome/browser/resources/settings/settings_menu/settings_menu.js - Issue 1870853003: Vulcanize settings (hacky and dirty, don't use)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_menu/settings_menu.js

Issue 1870853003: Vulcanize settings (hacky and dirty, don't use) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: git squash commit. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/settings_menu/settings_menu.js

diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.js b/chrome/browser/resources/settings/settings_menu/settings_menu.js

index d2a4c90547977df353e16b76a8f876d4c5389822..8b7be9ea70f1b0fad7799be5f6962e0d504185be 100644

--- a/chrome/browser/resources/settings/settings_menu/settings_menu.js

+++ b/chrome/browser/resources/settings/settings_menu/settings_menu.js

@@ -40,7 +40,9 @@ Polymer({

this.fire('toggle-advanced-page', false);

}.bind(this));

- this.fire('toggle-advanced-page', this.currentRoute.page == 'advanced');

+ // TODO(michaelpg): Why is this.currentRoute undefined when vulcanized?

+ this.fire('toggle-advanced-page',

+ this.currentRoute && this.currentRoute.page == 'advanced');

/**