chrome/browser/resources/vulcanize_readme.md - Issue 1870853003: Vulcanize settings (hacky and dirty, don't use)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/vulcanize_readme.md

Issue 1870853003: Vulcanize settings (hacky and dirty, don't use) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: git squash commit. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/vulcanize.py ('K') | « chrome/browser/resources/vulcanize.py ('k') | chrome/browser/ui/webui/settings/md_settings_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/vulcanize_readme.md

diff --git a/chrome/browser/resources/md_downloads/vulcanize_readme.md b/chrome/browser/resources/vulcanize_readme.md

similarity index 65%

rename from chrome/browser/resources/md_downloads/vulcanize_readme.md

rename to chrome/browser/resources/vulcanize_readme.md

index 2be2248ada9519cdbea8f3a6e47bdcd474ada76f..2e2838f0bda5d929618c4f28bc51c7ac2f462082 100644

--- a/chrome/browser/resources/md_downloads/vulcanize_readme.md

+++ b/chrome/browser/resources/vulcanize_readme.md

@@ -1,8 +1,8 @@

-# Vulcanizing Material Design downloads

+# Vulcanizing Material Design WebUI

`vulcanize` is an npm module used to combine resources. In order to make the

-Material Design downloads page sufficiently fast, we run vulcanize on the source

-files to combine them and reduce blocking load/parse time.

+Material Design downloads and settings pages sufficiently fast, we run vulcanize

+on the source files to combine them and reduce blocking load/parse time.

## Required software

@@ -35,11 +35,11 @@ Ultimately, all that is required to run this script is that `crisper` and

## Combining resources with vulcanize

-To combine all the CSS/HTML/JS for the downloads page to make it production

-fast, you can run the commands:

+To combine all the CSS/HTML/JS for the Material Design downloads and ettings

+pages to make them production fast, you can run the command:

```bash

-$ chrome/browser/resources/md_downloads/vulcanize.py # from src/

+$ chrome/browser/resources/vulcanize.py # from src/

```

This should overwrite the following files:

@@ -47,8 +47,11 @@ This should overwrite the following files:

- chrome/browser/resources/md_downloads/

- vulcanized.html (all <link rel=import> and stylesheets inlined)

- crisper.js (all JavaScript, extracted from vulcanized.html)

+- chrome/browser/resources/settings/

+ - vulcanized.html (all <link rel=import> and stylesheets inlined)

+ - crisper.js (all JavaScript, extracted from vulcanized.html)

-## Testing downloads without vulcanizing

+## Testing pages without vulcanizing

-Build with "use_vulcanize=0" in your GYP_DEFINES to build downloads without

-vulcanizing.

+Build with "use_vulcanize=0" in your GYP_DEFINES to build downloads and settings

+without vulcanizing.

« chrome/browser/resources/settings/vulcanize.py ('K') | « chrome/browser/resources/vulcanize.py ('k') | chrome/browser/ui/webui/settings/md_settings_ui.cc » ('j') | no next file with comments »