chrome/browser/resources/md_downloads/vulcanize_readme.md - Issue 1870853003: Vulcanize settings (hacky and dirty, don't use)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/md_downloads/vulcanize_readme.md

Issue 1870853003: Vulcanize settings (hacky and dirty, don't use) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: git squash commit. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/PRESUBMIT.py ('k') | chrome/browser/resources/settings/flatten_settings.py » ('j') | chrome/browser/resources/settings/vulcanize.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/md_downloads/vulcanize_readme.md

diff --git a/chrome/browser/resources/md_downloads/vulcanize_readme.md b/chrome/browser/resources/md_downloads/vulcanize_readme.md

deleted file mode 100644

index 2be2248ada9519cdbea8f3a6e47bdcd474ada76f..0000000000000000000000000000000000000000

--- a/chrome/browser/resources/md_downloads/vulcanize_readme.md

+++ /dev/null

@@ -1,54 +0,0 @@

-# Vulcanizing Material Design downloads

-`vulcanize` is an npm module used to combine resources. In order to make the

-Material Design downloads page sufficiently fast, we run vulcanize on the source

-files to combine them and reduce blocking load/parse time.

-## Required software

-Vulcanization currently requires:

-- node.js: >= v4.4.2 (can be found with `node --version`)

-- npm: >= 1.3.10 (can be found with `npm --version`)

-- vulcanize: 1.14.8 (can be found with `vulcanize --version`)

-- crisper: 2.0.1 (can be found with `npm list -g crisper`)

-## Installing required software

-For instructions on installing node and npm, see

-[here](https://docs.npmjs.com/getting-started/installing-node).

-We recommend telling npm where to store downloaded modules:

-```bash

-$ npm config set -g prefix "$HOME/node_modules"

-```

-Then install `crisper` and `vulcanize` like this:

-```bash

-$ npm install -g crisper vulcanize

-```

-Ultimately, all that is required to run this script is that `crisper` and

-`vulcanize` are on your `$PATH`.

-## Combining resources with vulcanize

-To combine all the CSS/HTML/JS for the downloads page to make it production

-fast, you can run the commands:

-```bash

-$ chrome/browser/resources/md_downloads/vulcanize.py # from src/

-```

-This should overwrite the following files:

-- chrome/browser/resources/md_downloads/

- - vulcanized.html (all <link rel=import> and stylesheets inlined)

- - crisper.js (all JavaScript, extracted from vulcanized.html)

-## Testing downloads without vulcanizing

-Build with "use_vulcanize=0" in your GYP_DEFINES to build downloads without

-vulcanizing.

« no previous file with comments | « chrome/browser/PRESUBMIT.py ('k') | chrome/browser/resources/settings/flatten_settings.py » ('j') | chrome/browser/resources/settings/vulcanize.py » ('J')