Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 1870573003: Full Keyboard Access: Second Approach (Closed)

Created:
4 years, 8 months ago by karandeepb
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews, tim+watch_chromium.org, msramek+watch_chromium.org, yusukes+watch_chromium.org, vabr+watchlistpasswordmanager_chromium.org, zea+watch_chromium.org, nona+watch_chromium.org, rouslan+autofill_chromium.org, tfarina, maxbogue+watch_chromium.org, shuchen+watch_chromium.org, raymes+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, plaree+watch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, James Su, markusheintz_, mkwst+watchlist-passwords_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -76 lines) Patch
M chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/desktop_media_picker_views.cc View 1 2 3 4 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/find_bar_view.cc View 1 2 3 4 4 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/infobars/infobar_view.cc View 1 2 3 4 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_icon_view.cc View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/passwords/credentials_item_view.cc View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_icon_views.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 2 3 4 4 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/app_menu.cc View 1 2 3 4 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_action_view.cc View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_button.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/website_settings/chosen_object_view.cc View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/website_settings/permission_selector_view.cc View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/cocoa/bridged_content_view.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/cocoa/bridged_content_view.mm View 1 2 3 4 6 chunks +34 lines, -0 lines 0 comments Download
M ui/views/cocoa/bridged_native_widget.mm View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/color_chooser/color_chooser_view.cc View 1 2 3 4 4 chunks +7 lines, -3 lines 0 comments Download
M ui/views/controls/button/checkbox.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/controls/button/custom_button.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/button/image_button.h View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/views/controls/button/label_button.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/controls/button/md_text_button.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/controls/combobox/combobox.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M ui/views/controls/label.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/views/controls/link.cc View 1 2 3 4 3 chunks +7 lines, -4 lines 0 comments Download
M ui/views/controls/menu/menu_controller_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/controls/scrollbar/native_scroll_bar_views.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M ui/views/controls/separator.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/controls/slider.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/controls/tabbed_pane/tabbed_pane.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/controls/table/table_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/controls/textfield/textfield.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/controls/tree/tree_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/controls/webview/webview.cc View 1 2 3 4 2 chunks +4 lines, -1 line 0 comments Download
M ui/views/examples/button_example.cc View 1 2 3 3 chunks +3 lines, -2 lines 0 comments Download
M ui/views/examples/tree_view_example.cc View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M ui/views/examples/widget_example.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/focus/focus_manager.h View 4 chunks +20 lines, -1 line 0 comments Download
M ui/views/focus/focus_manager.cc View 5 chunks +24 lines, -5 lines 0 comments Download
M ui/views/focus/focus_manager_unittest.cc View 1 2 3 1 chunk +9 lines, -5 lines 0 comments Download
M ui/views/focus/focus_search.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/focus/focus_search.cc View 3 chunks +9 lines, -1 line 0 comments Download
M ui/views/style/platform_style.h View 1 2 3 4 2 chunks +26 lines, -1 line 0 comments Download
M ui/views/style/platform_style.cc View 1 2 3 4 1 chunk +33 lines, -0 lines 0 comments Download
M ui/views/style/platform_style_mac.mm View 1 2 3 4 1 chunk +33 lines, -0 lines 0 comments Download
M ui/views/touchui/touch_selection_menu_runner_views.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/window/dialog_client_view.cc View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 1 (1 generated)
karandeepb
4 years, 8 months ago (2016-04-07 05:57:56 UTC) #1
Description was changed from

==========
-----


-----


Remove commit


Remove commit


---


---


---


Remove this commit


----


----


----


Initial commit

BUG=
==========

to

==========

==========

Powered by Google App Engine
This is Rietveld 408576698