Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: chrome/browser/ui/views/website_settings/chosen_object_view.cc

Issue 1870573003: Full Keyboard Access: Second Approach (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/website_settings/chosen_object_view.h" 5 #include "chrome/browser/ui/views/website_settings/chosen_object_view.h"
6 6
7 #include "chrome/browser/ui/views/website_settings/chosen_object_view_observer.h " 7 #include "chrome/browser/ui/views/website_settings/chosen_object_view_observer.h "
8 #include "chrome/browser/ui/views/website_settings/website_settings_popup_view.h " 8 #include "chrome/browser/ui/views/website_settings/website_settings_popup_view.h "
9 #include "ui/base/resource/resource_bundle.h" 9 #include "ui/base/resource/resource_bundle.h"
10 #include "ui/resources/grit/ui_resources.h" 10 #include "ui/resources/grit/ui_resources.h"
11 #include "ui/views/controls/button/image_button.h" 11 #include "ui/views/controls/button/image_button.h"
12 #include "ui/views/controls/image_view.h" 12 #include "ui/views/controls/image_view.h"
13 #include "ui/views/controls/label.h" 13 #include "ui/views/controls/label.h"
14 #include "ui/views/layout/grid_layout.h" 14 #include "ui/views/layout/grid_layout.h"
15 #include "ui/views/style/platform_style.h"
15 16
16 ChosenObjectView::ChosenObjectView( 17 ChosenObjectView::ChosenObjectView(
17 std::unique_ptr<WebsiteSettingsUI::ChosenObjectInfo> info) 18 std::unique_ptr<WebsiteSettingsUI::ChosenObjectInfo> info)
18 : info_(std::move(info)) { 19 : info_(std::move(info)) {
19 views::GridLayout* layout = new views::GridLayout(this); 20 views::GridLayout* layout = new views::GridLayout(this);
20 SetLayoutManager(layout); 21 SetLayoutManager(layout);
21 const int column_set_id = 0; 22 const int column_set_id = 0;
22 views::ColumnSet* column_set = layout->AddColumnSet(column_set_id); 23 views::ColumnSet* column_set = layout->AddColumnSet(column_set_id);
23 column_set->AddColumn(views::GridLayout::FILL, views::GridLayout::FILL, 1, 24 column_set->AddColumn(views::GridLayout::FILL, views::GridLayout::FILL, 1,
24 views::GridLayout::FIXED, kPermissionIconColumnWidth, 25 views::GridLayout::FIXED, kPermissionIconColumnWidth,
(...skipping 13 matching lines...) Expand all
38 layout->AddView(icon_, 1, 1, views::GridLayout::CENTER, 39 layout->AddView(icon_, 1, 1, views::GridLayout::CENTER,
39 views::GridLayout::CENTER); 40 views::GridLayout::CENTER);
40 // Create the label that displays the permission type. 41 // Create the label that displays the permission type.
41 views::Label* label = new views::Label(l10n_util::GetStringFUTF16( 42 views::Label* label = new views::Label(l10n_util::GetStringFUTF16(
42 info_->ui_info.label_string_id, 43 info_->ui_info.label_string_id,
43 WebsiteSettingsUI::ChosenObjectToUIString(*info_))); 44 WebsiteSettingsUI::ChosenObjectToUIString(*info_)));
44 layout->AddView(label, 1, 1, views::GridLayout::LEADING, 45 layout->AddView(label, 1, 1, views::GridLayout::LEADING,
45 views::GridLayout::CENTER); 46 views::GridLayout::CENTER);
46 // Create the delete button. 47 // Create the delete button.
47 delete_button_ = new views::ImageButton(this); 48 delete_button_ = new views::ImageButton(this);
48 delete_button_->SetFocusable(true); 49 views::PlatformStyle::ConfigureFocus(views::PlatformStyle::CONTROL::BUTTON,
50 delete_button_);
49 delete_button_->SetTooltipText( 51 delete_button_->SetTooltipText(
50 l10n_util::GetStringUTF16(info_->ui_info.delete_tooltip_string_id)); 52 l10n_util::GetStringUTF16(info_->ui_info.delete_tooltip_string_id));
51 ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance(); 53 ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
52 delete_button_->SetImage(views::ImageButton::STATE_NORMAL, 54 delete_button_->SetImage(views::ImageButton::STATE_NORMAL,
53 rb.GetImageSkiaNamed(IDR_CLOSE_2)); 55 rb.GetImageSkiaNamed(IDR_CLOSE_2));
54 delete_button_->SetImage(views::ImageButton::STATE_HOVERED, 56 delete_button_->SetImage(views::ImageButton::STATE_HOVERED,
55 rb.GetImageSkiaNamed(IDR_CLOSE_2_H)); 57 rb.GetImageSkiaNamed(IDR_CLOSE_2_H));
56 delete_button_->SetImage(views::ImageButton::STATE_PRESSED, 58 delete_button_->SetImage(views::ImageButton::STATE_PRESSED,
57 rb.GetImageSkiaNamed(IDR_CLOSE_2_P)); 59 rb.GetImageSkiaNamed(IDR_CLOSE_2_P));
58 layout->AddView(delete_button_, 1, 1, views::GridLayout::LEADING, 60 layout->AddView(delete_button_, 1, 1, views::GridLayout::LEADING,
(...skipping 13 matching lines...) Expand all
72 WebsiteSettingsUI::GetChosenObjectIcon(*info_, true); 74 WebsiteSettingsUI::GetChosenObjectIcon(*info_, true);
73 icon_->SetImage(image.ToImageSkia()); 75 icon_->SetImage(image.ToImageSkia());
74 76
75 RemoveChildView(delete_button_); 77 RemoveChildView(delete_button_);
76 delete delete_button_; 78 delete delete_button_;
77 delete_button_ = nullptr; 79 delete_button_ = nullptr;
78 80
79 FOR_EACH_OBSERVER(ChosenObjectViewObserver, observer_list_, 81 FOR_EACH_OBSERVER(ChosenObjectViewObserver, observer_list_,
80 OnChosenObjectDeleted(*info_)); 82 OnChosenObjectDeleted(*info_));
81 } 83 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698