Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4165)

Unified Diff: chrome/browser/ui/views/profiles/profile_chooser_view.cc

Issue 1870573003: Full Keyboard Access: Second Approach (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/profiles/profile_chooser_view.cc
diff --git a/chrome/browser/ui/views/profiles/profile_chooser_view.cc b/chrome/browser/ui/views/profiles/profile_chooser_view.cc
index 057ddfbc5ec017ed12f97cc7f7f9578a81c6d3bf..8fee5df403b174ab01d8dc3703aa7cffc34e16de 100644
--- a/chrome/browser/ui/views/profiles/profile_chooser_view.cc
+++ b/chrome/browser/ui/views/profiles/profile_chooser_view.cc
@@ -75,6 +75,7 @@
#include "ui/views/layout/fill_layout.h"
#include "ui/views/layout/grid_layout.h"
#include "ui/views/layout/layout_constants.h"
+#include "ui/views/style/platform_style.h"
#include "ui/views/widget/widget.h"
namespace {
@@ -154,7 +155,8 @@ views::ImageButton* CreateBackButton(views::ButtonListener* listener) {
rb->GetImageSkiaNamed(IDR_BACK_P));
back_button->SetImage(views::ImageButton::STATE_DISABLED,
rb->GetImageSkiaNamed(IDR_BACK_D));
- back_button->SetFocusable(true);
+ views::PlatformStyle::ConfigureFocus(views::PlatformStyle::CONTROL::BUTTON,
+ back_button);
return back_button;
}
@@ -173,7 +175,8 @@ class BackgroundColorHoverButton : public views::LabelButton {
SetMinSize(gfx::Size(0,
kButtonHeight + views::kRelatedControlVerticalSpacing));
SetImage(STATE_NORMAL, icon);
- SetFocusable(true);
+ views::PlatformStyle::ConfigureFocus(views::PlatformStyle::CONTROL::BUTTON,
+ this);
}
~BackgroundColorHoverButton() override {}
@@ -1395,8 +1398,8 @@ views::View* ProfileChooserView::CreateCurrentProfileView(
views::LabelButton::STATE_NORMAL,
gfx::CreateVectorIcon(gfx::VectorIconId::WARNING, 18,
gfx::kChromeIconGrey));
-
- auth_error_email_button_->SetFocusable(true);
+ views::PlatformStyle::ConfigureFocus(
+ views::PlatformStyle::CONTROL::BUTTON, auth_error_email_button_);
gfx::Insets insets =
views::LabelButtonAssetBorder::GetDefaultInsetsForStyle(
views::Button::STYLE_TEXTBUTTON);

Powered by Google App Engine
This is Rietveld 408576698