Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(978)

Unified Diff: chrome/browser/ui/views/find_bar_view.cc

Issue 1870573003: Full Keyboard Access: Second Approach (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/find_bar_view.cc
diff --git a/chrome/browser/ui/views/find_bar_view.cc b/chrome/browser/ui/views/find_bar_view.cc
index 3f6031b7b1d52b24aa496f49431b0dec8d16510c..6b959f8bf9cd0b40d75e892d2eaa06bbf6294526 100644
--- a/chrome/browser/ui/views/find_bar_view.cc
+++ b/chrome/browser/ui/views/find_bar_view.cc
@@ -48,6 +48,7 @@
#include "ui/views/controls/separator.h"
#include "ui/views/layout/box_layout.h"
#include "ui/views/painter.h"
+#include "ui/views/style/platform_style.h"
#include "ui/views/view_targeter.h"
#include "ui/views/widget/widget.h"
@@ -154,7 +155,8 @@ FindBarView::FindBarView(FindBarHost* host)
}
find_previous_button_->set_id(VIEW_ID_FIND_IN_PAGE_PREVIOUS_BUTTON);
- find_previous_button_->SetFocusable(true);
+ views::PlatformStyle::ConfigureFocus(views::PlatformStyle::CONTROL::BUTTON,
+ find_previous_button_);
find_previous_button_->set_request_focus_on_press(false);
find_previous_button_->SetTooltipText(
l10n_util::GetStringUTF16(IDS_FIND_IN_PAGE_PREVIOUS_TOOLTIP));
@@ -163,7 +165,8 @@ FindBarView::FindBarView(FindBarHost* host)
AddChildView(find_previous_button_);
find_next_button_->set_id(VIEW_ID_FIND_IN_PAGE_NEXT_BUTTON);
- find_next_button_->SetFocusable(true);
+ views::PlatformStyle::ConfigureFocus(views::PlatformStyle::CONTROL::BUTTON,
+ find_next_button_);
find_next_button_->set_request_focus_on_press(false);
find_next_button_->SetTooltipText(
l10n_util::GetStringUTF16(IDS_FIND_IN_PAGE_NEXT_TOOLTIP));
@@ -172,7 +175,8 @@ FindBarView::FindBarView(FindBarHost* host)
AddChildView(find_next_button_);
close_button_->set_id(VIEW_ID_FIND_IN_PAGE_CLOSE_BUTTON);
- close_button_->SetFocusable(true);
+ views::PlatformStyle::ConfigureFocus(views::PlatformStyle::CONTROL::BUTTON,
+ close_button_);
close_button_->set_request_focus_on_press(false);
close_button_->SetTooltipText(
l10n_util::GetStringUTF16(IDS_FIND_IN_PAGE_CLOSE_TOOLTIP));
« no previous file with comments | « chrome/browser/ui/views/desktop_media_picker_views.cc ('k') | chrome/browser/ui/views/infobars/infobar_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698