Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1869983003: cc: Clean up helper function from layer tree host common (Closed)

Created:
4 years, 8 months ago by weiliangc
Modified:
4 years, 8 months ago
Reviewers:
ajuma, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@targetid
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Clean up helper function from layer tree host common After removal of CDP, helper functions can be de-templated and cleaned up. R=ajuma, enne BUG=581832 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/4012ef768e802a281461207edad2624524d462ae Cr-Commit-Position: refs/heads/master@{#386486}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -56 lines) Patch
M cc/debug/debug_rect_history.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M cc/layers/layer_iterator.h View 1 chunk +3 lines, -4 lines 0 comments Download
M cc/trees/damage_tracker.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M cc/trees/damage_tracker.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download
M cc/trees/damage_tracker_unittest.cc View 1 2 chunks +2 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_host_common.h View 1 3 chunks +0 lines, -31 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (6 generated)
weiliangc
Drive-by clean up.
4 years, 8 months ago (2016-04-09 00:01:36 UTC) #2
enne (OOO)
lgtm
4 years, 8 months ago (2016-04-09 00:10:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869983003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869983003/1
4 years, 8 months ago (2016-04-11 18:38:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/167040) linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 8 months ago (2016-04-11 18:42:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869983003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869983003/20001
4 years, 8 months ago (2016-04-11 20:13:12 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-11 22:04:19 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 22:05:29 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4012ef768e802a281461207edad2624524d462ae
Cr-Commit-Position: refs/heads/master@{#386486}

Powered by Google App Engine
This is Rietveld 408576698