Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Side by Side Diff: cc/trees/damage_tracker_unittest.cc

Issue 1869983003: cc: Clean up helper function from layer tree host common (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@targetid
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/trees/damage_tracker.cc ('k') | cc/trees/layer_tree_host_common.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/trees/damage_tracker.h" 5 #include "cc/trees/damage_tracker.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "cc/base/math_util.h" 9 #include "cc/base/math_util.h"
10 #include "cc/layers/layer_impl.h" 10 #include "cc/layers/layer_impl.h"
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 ExecuteCalculateDrawProperties(root, &render_surface_layer_list); 62 ExecuteCalculateDrawProperties(root, &render_surface_layer_list);
63 63
64 // Iterate back-to-front, so that damage correctly propagates from descendant 64 // Iterate back-to-front, so that damage correctly propagates from descendant
65 // surfaces to ancestors. 65 // surfaces to ancestors.
66 size_t render_surface_layer_list_size = render_surface_layer_list.size(); 66 size_t render_surface_layer_list_size = render_surface_layer_list.size();
67 for (size_t i = 0; i < render_surface_layer_list_size; ++i) { 67 for (size_t i = 0; i < render_surface_layer_list_size; ++i) {
68 size_t index = render_surface_layer_list_size - 1 - i; 68 size_t index = render_surface_layer_list_size - 1 - i;
69 RenderSurfaceImpl* target_surface = 69 RenderSurfaceImpl* target_surface =
70 render_surface_layer_list[index]->render_surface(); 70 render_surface_layer_list[index]->render_surface();
71 target_surface->damage_tracker()->UpdateDamageTrackingState( 71 target_surface->damage_tracker()->UpdateDamageTrackingState(
72 target_surface->layer_list(), target_surface->OwningLayerId(), 72 target_surface->layer_list(), target_surface,
73 target_surface->SurfacePropertyChangedOnlyFromDescendant(), 73 target_surface->SurfacePropertyChangedOnlyFromDescendant(),
74 target_surface->content_rect(), 74 target_surface->content_rect(),
75 render_surface_layer_list[index]->mask_layer(), 75 render_surface_layer_list[index]->mask_layer(),
76 render_surface_layer_list[index]->filters()); 76 render_surface_layer_list[index]->filters());
77 } 77 }
78 78
79 root->layer_tree_impl()->ResetAllChangeTracking( 79 root->layer_tree_impl()->ResetAllChangeTracking(
80 PropertyTrees::ResetFlags::ALL_TREES); 80 PropertyTrees::ResetFlags::ALL_TREES);
81 } 81 }
82 82
(...skipping 1388 matching lines...) Expand 10 before | Expand all | Expand 10 after
1471 host_impl_.active_tree()->SetRootLayer(std::move(root)); 1471 host_impl_.active_tree()->SetRootLayer(std::move(root));
1472 LayerImpl* root_ptr = host_impl_.active_tree()->root_layer(); 1472 LayerImpl* root_ptr = host_impl_.active_tree()->root_layer();
1473 root_ptr->layer_tree_impl()->property_trees()->needs_rebuild = true; 1473 root_ptr->layer_tree_impl()->property_trees()->needs_rebuild = true;
1474 EmulateDrawingOneFrame(root_ptr); 1474 EmulateDrawingOneFrame(root_ptr);
1475 1475
1476 DCHECK_EQ(root_ptr->render_surface(), root_ptr->render_target()); 1476 DCHECK_EQ(root_ptr->render_surface(), root_ptr->render_target());
1477 RenderSurfaceImpl* target_surface = root_ptr->render_surface(); 1477 RenderSurfaceImpl* target_surface = root_ptr->render_surface();
1478 1478
1479 LayerImplList empty_list; 1479 LayerImplList empty_list;
1480 target_surface->damage_tracker()->UpdateDamageTrackingState( 1480 target_surface->damage_tracker()->UpdateDamageTrackingState(
1481 empty_list, 1481 empty_list, target_surface, false, gfx::Rect(), NULL, FilterOperations());
1482 target_surface->OwningLayerId(),
1483 false,
1484 gfx::Rect(),
1485 NULL,
1486 FilterOperations());
1487 1482
1488 gfx::Rect damage_rect = 1483 gfx::Rect damage_rect =
1489 target_surface->damage_tracker()->current_damage_rect(); 1484 target_surface->damage_tracker()->current_damage_rect();
1490 EXPECT_TRUE(damage_rect.IsEmpty()); 1485 EXPECT_TRUE(damage_rect.IsEmpty());
1491 } 1486 }
1492 1487
1493 TEST_F(DamageTrackerTest, VerifyDamageAccumulatesUntilReset) { 1488 TEST_F(DamageTrackerTest, VerifyDamageAccumulatesUntilReset) {
1494 // If damage is not cleared, it should accumulate. 1489 // If damage is not cleared, it should accumulate.
1495 1490
1496 LayerImpl* root = CreateAndSetUpTestTreeWithOneSurface(); 1491 LayerImpl* root = CreateAndSetUpTestTreeWithOneSurface();
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
1559 gfx::Rect root_damage_rect = 1554 gfx::Rect root_damage_rect =
1560 root->render_surface()->damage_tracker()->current_damage_rect(); 1555 root->render_surface()->damage_tracker()->current_damage_rect();
1561 gfx::Rect damage_we_care_about = gfx::Rect(i, i); 1556 gfx::Rect damage_we_care_about = gfx::Rect(i, i);
1562 EXPECT_LE(damage_we_care_about.right(), root_damage_rect.right()); 1557 EXPECT_LE(damage_we_care_about.right(), root_damage_rect.right());
1563 EXPECT_LE(damage_we_care_about.bottom(), root_damage_rect.bottom()); 1558 EXPECT_LE(damage_we_care_about.bottom(), root_damage_rect.bottom());
1564 } 1559 }
1565 } 1560 }
1566 1561
1567 } // namespace 1562 } // namespace
1568 } // namespace cc 1563 } // namespace cc
OLDNEW
« no previous file with comments | « cc/trees/damage_tracker.cc ('k') | cc/trees/layer_tree_host_common.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698