cc: Move RenderTarget Information to Effect Tree

cc: Move RenderTarget Information to Effect Tree

Move render target related information to effect tree and clean up
render target logic.

This CL's major change includes:
1. Effect node's target_id is updated every frame
2. Effect node's target_id always points to closest ancestor that has a
    render surface, and never points to itself.
3. LayerImpl's render target returns the RenderSurfaceImpl that the
    layer contributes to. It is possible the LayerImpl owns that
    RenderSurfaceImpl.
4. RenderSurfaceImpl's render target returns the RenderSurfaceImpl that
    the render surface contributes to.

Resulting from this CL, effect tree can be walked upwards using
target_id, and render target information can be queried from effect
tree.

R=ajuma, enne
BUG=504464, 594675
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/189c1a15ccd8cb50b9c1c21f786120b1e8ad1077
Cr-Commit-Position: refs/heads/master@{#386399}

[weiliangc, 2016-04-07 20:53:52]

Description was changed from

==========
cc: Move RenderTarget Information to Effect Tree

Move render target related information to effect tree and clean up
render target logic.

This CL's major change includes:
1. Effect node's target_id is updated every frame
2. Effect node's target_id always points to closest ancestor that has a
    render surface, and never points to itself.
3. LayerImpl's render target returns the RenderSurfaceImpl that the
    layer contributes to. It is possible the LayerImpl owns that
    RenderSurfaceImpl.
4. RenderSurfaceImpl's render target returns the RenderSurfaceImpl that
    the render surface contributes to.

Resulting from this CL, effect tree can be walked upwards using
target_id, and render target information can be queried from effect
tree.

R=ajuma, enne
BUG=504464
==========

to

==========
cc: Move RenderTarget Information to Effect Tree

Move render target related information to effect tree and clean up
render target logic.

This CL's major change includes:
1. Effect node's target_id is updated every frame
2. Effect node's target_id always points to closest ancestor that has a
    render surface, and never points to itself.
3. LayerImpl's render target returns the RenderSurfaceImpl that the
    layer contributes to. It is possible the LayerImpl owns that
    RenderSurfaceImpl.
4. RenderSurfaceImpl's render target returns the RenderSurfaceImpl that
    the render surface contributes to.

Resulting from this CL, effect tree can be walked upwards using
target_id, and render target information can be queried from effect
tree.

R=ajuma, enne
BUG=504464
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[weiliangc, 2016-04-07 20:56:43]

Description was changed from

==========
cc: Move RenderTarget Information to Effect Tree

Move render target related information to effect tree and clean up
render target logic.

This CL's major change includes:
1. Effect node's target_id is updated every frame
2. Effect node's target_id always points to closest ancestor that has a
    render surface, and never points to itself.
3. LayerImpl's render target returns the RenderSurfaceImpl that the
    layer contributes to. It is possible the LayerImpl owns that
    RenderSurfaceImpl.
4. RenderSurfaceImpl's render target returns the RenderSurfaceImpl that
    the render surface contributes to.

Resulting from this CL, effect tree can be walked upwards using
target_id, and render target information can be queried from effect
tree.

R=ajuma, enne
BUG=504464
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Move RenderTarget Information to Effect Tree

Move render target related information to effect tree and clean up
render target logic.

This CL's major change includes:
1. Effect node's target_id is updated every frame
2. Effect node's target_id always points to closest ancestor that has a
    render surface, and never points to itself.
3. LayerImpl's render target returns the RenderSurfaceImpl that the
    layer contributes to. It is possible the LayerImpl owns that
    RenderSurfaceImpl.
4. RenderSurfaceImpl's render target returns the RenderSurfaceImpl that
    the render surface contributes to.

Resulting from this CL, effect tree can be walked upwards using
target_id, and render target information can be queried from effect
tree.

R=ajuma, enne
BUG=504464, 594675
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[weiliangc, 2016-04-07 20:58:58]

Help effect tree to find render target. Please take a look.

[ajuma, 2016-04-07 21:59:55]

lgtm

https://codereview.chromium.org/1868003002/diff/1/cc/layers/render_surface_im...
File cc/layers/render_surface_impl.cc (right):

https://codereview.chromium.org/1868003002/diff/1/cc/layers/render_surface_im...
cc/layers/render_surface_impl.cc:177:
accumulated_content_rect_.Intersect(clip_rect());
This clipping seems like something that can be removed too, since I think we'll
apply this clip later before calling SetContentRect.

https://codereview.chromium.org/1868003002/diff/1/cc/trees/layer_tree_host_co...
File cc/trees/layer_tree_host_common.h (right):

https://codereview.chromium.org/1868003002/diff/1/cc/trees/layer_tree_host_co...
cc/trees/layer_tree_host_common.h:190: LayerType* layer,
Note for future cleanup: this can be detemplatized.

[ajuma, 2016-04-07 23:57:37]

https://codereview.chromium.org/1868003002/diff/1/cc/layers/render_surface_im...
File cc/layers/render_surface_impl.cc (right):

https://codereview.chromium.org/1868003002/diff/1/cc/layers/render_surface_im...
cc/layers/render_surface_impl.cc:177:
accumulated_content_rect_.Intersect(clip_rect());
On 2016/04/07 21:59:55, ajuma wrote:
> This clipping seems like something that can be removed too, since I think
we'll
> apply this clip later before calling SetContentRect.

Thinking about this some more:
In the old code, the contributing surface's drawable content rect is intersected
with the clip rect of the layer that owns the surface. That clip rect is in
surface space. But I don't see why it makes sense to intersect that way, since
the clip rect of the layer that owns the surface isn't going to be used to clip
the contributing surface at draw time.

And here, clip_rect() is actually in the space of the surface's target, so if we
wanted to intersect with it, we'd need to put the accumulated content rect into
the surface's target space, intersect there, and then project back. But that
already gets done before SetContentRect.

[weiliangc, 2016-04-09 00:01:04]

Removed the intersection of clip_rect while accumulating content rect from
render surface.
Added early out to ignore accumulating for root render surface.
Rebased.

[ajuma, 2016-04-11 13:12:32]

Thanks, still lgtm.

[weiliangc, 2016-04-11 15:10:50]

The CQ bit was checked by weiliangc@chromium.org

[commit-bot: I haz the power, 2016-04-11 15:11:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1868003002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1868003002/40001

[commit-bot: I haz the power, 2016-04-11 16:16:33]

Description was changed from

==========
cc: Move RenderTarget Information to Effect Tree

Move render target related information to effect tree and clean up
render target logic.

This CL's major change includes:
1. Effect node's target_id is updated every frame
2. Effect node's target_id always points to closest ancestor that has a
    render surface, and never points to itself.
3. LayerImpl's render target returns the RenderSurfaceImpl that the
    layer contributes to. It is possible the LayerImpl owns that
    RenderSurfaceImpl.
4. RenderSurfaceImpl's render target returns the RenderSurfaceImpl that
    the render surface contributes to.

Resulting from this CL, effect tree can be walked upwards using
target_id, and render target information can be queried from effect
tree.

R=ajuma, enne
BUG=504464, 594675
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Move RenderTarget Information to Effect Tree

Move render target related information to effect tree and clean up
render target logic.

This CL's major change includes:
1. Effect node's target_id is updated every frame
2. Effect node's target_id always points to closest ancestor that has a
    render surface, and never points to itself.
3. LayerImpl's render target returns the RenderSurfaceImpl that the
    layer contributes to. It is possible the LayerImpl owns that
    RenderSurfaceImpl.
4. RenderSurfaceImpl's render target returns the RenderSurfaceImpl that
    the render surface contributes to.

Resulting from this CL, effect tree can be walked upwards using
target_id, and render target information can be queried from effect
tree.

R=ajuma, enne
BUG=504464, 594675
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-04-11 16:16:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-11 16:18:16]

Description was changed from

==========
cc: Move RenderTarget Information to Effect Tree

Move render target related information to effect tree and clean up
render target logic.

This CL's major change includes:
1. Effect node's target_id is updated every frame
2. Effect node's target_id always points to closest ancestor that has a
    render surface, and never points to itself.
3. LayerImpl's render target returns the RenderSurfaceImpl that the
    layer contributes to. It is possible the LayerImpl owns that
    RenderSurfaceImpl.
4. RenderSurfaceImpl's render target returns the RenderSurfaceImpl that
    the render surface contributes to.

Resulting from this CL, effect tree can be walked upwards using
target_id, and render target information can be queried from effect
tree.

R=ajuma, enne
BUG=504464, 594675
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Move RenderTarget Information to Effect Tree

Move render target related information to effect tree and clean up
render target logic.

This CL's major change includes:
1. Effect node's target_id is updated every frame
2. Effect node's target_id always points to closest ancestor that has a
    render surface, and never points to itself.
3. LayerImpl's render target returns the RenderSurfaceImpl that the
    layer contributes to. It is possible the LayerImpl owns that
    RenderSurfaceImpl.
4. RenderSurfaceImpl's render target returns the RenderSurfaceImpl that
    the render surface contributes to.

Resulting from this CL, effect tree can be walked upwards using
target_id, and render target information can be queried from effect
tree.

R=ajuma, enne
BUG=504464, 594675
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/189c1a15ccd8cb50b9c1c21f786120b1e8ad1077
Cr-Commit-Position: refs/heads/master@{#386399}
==========

[commit-bot: I haz the power, 2016-04-11 16:18:17]

Patchset 3 (id:??) landed as
https://crrev.com/189c1a15ccd8cb50b9c1c21f786120b1e8ad1077
Cr-Commit-Position: refs/heads/master@{#386399}