cc: Move calculation of content rect to RenderSurfaceImpl class

cc: Move calculation of content rect to RenderSurfaceImpl class

Calculation of content rect used to live in LayerTreeHostCommon, but is
only useful for render surface. Move it to RenderSurfaceImpl class.
Render surface now hides the SetContentRect function.

This also leads to deletion of helper function CalculateVisibleRect
since it's only used in calculating content rect.

BUG=504464
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/6da3286eca2180a66a6cb433f4d1f58f11011cfc
Cr-Commit-Position: refs/heads/master@{#388520}

[weiliangc, 2016-04-19 17:50:51]

Description was changed from

==========
cc: Move calculation of content rect to RenderSurfaceImpl class

Calculation of content rect used to live in LayerTreeHostCommon, but is
only useful for render surface. Move it to RenderSurfaceImpl class.
Render surface now hides the SetContentRect function.

This also leads to deletion of helper function CalculateVisibleRect
since it's only used in calculating content rect.

BUG=504464
==========

to

==========
cc: Move calculation of content rect to RenderSurfaceImpl class

Calculation of content rect used to live in LayerTreeHostCommon, but is
only useful for render surface. Move it to RenderSurfaceImpl class.
Render surface now hides the SetContentRect function.

This also leads to deletion of helper function CalculateVisibleRect
since it's only used in calculating content rect.

BUG=504464
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[weiliangc, 2016-04-19 17:59:14]

weiliangc@chromium.org changed reviewers:
+ ajuma@chromium.org

[weiliangc, 2016-04-19 18:00:04]

Still need to rebase, but the logic is the same. Please take a look.

[ajuma, 2016-04-19 19:20:37]

lgtm

https://codereview.chromium.org/1902893002/diff/1/cc/layers/render_surface_im...
File cc/layers/render_surface_impl.cc (right):

https://codereview.chromium.org/1902893002/diff/1/cc/layers/render_surface_im...
cc/layers/render_surface_impl.cc:192: // in inflationg due to axis-alignment.
typo: inflation

https://codereview.chromium.org/1902893002/diff/1/cc/layers/render_surface_im...
cc/layers/render_surface_impl.cc:202: }
Suggestion for making this easier to read: put this into a
ComputeClippedContentRect helper, and then early-return when you can early-out
instead of having nested if statements.

https://codereview.chromium.org/1902893002/diff/1/cc/trees/layer_tree_host_co...
File cc/trees/layer_tree_host_common_unittest.cc (right):

https://codereview.chromium.org/1902893002/diff/1/cc/trees/layer_tree_host_co...
cc/trees/layer_tree_host_common_unittest.cc:2913: // move a layer by translating
-50 units in projected surface units (so that
s/-50/-25

[weiliangc, 2016-04-20 15:58:28]

The CQ bit was checked by weiliangc@chromium.org

[weiliangc, 2016-04-20 15:58:28]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/1902893002/#ps60001
(title: "fix error")

[commit-bot: I haz the power, 2016-04-20 15:58:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902893002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902893002/60001

[commit-bot: I haz the power, 2016-04-20 16:40:25]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-22 19:24:21]

Description was changed from

==========
cc: Move calculation of content rect to RenderSurfaceImpl class

Calculation of content rect used to live in LayerTreeHostCommon, but is
only useful for render surface. Move it to RenderSurfaceImpl class.
Render surface now hides the SetContentRect function.

This also leads to deletion of helper function CalculateVisibleRect
since it's only used in calculating content rect.

BUG=504464
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Move calculation of content rect to RenderSurfaceImpl class

Calculation of content rect used to live in LayerTreeHostCommon, but is
only useful for render surface. Move it to RenderSurfaceImpl class.
Render surface now hides the SetContentRect function.

This also leads to deletion of helper function CalculateVisibleRect
since it's only used in calculating content rect.

BUG=504464
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/6da3286eca2180a66a6cb433f4d1f58f11011cfc
Cr-Commit-Position: refs/heads/master@{#388520}
==========

[commit-bot: I haz the power, 2016-04-22 19:24:22]

Patchset 4 (id:??) landed as
https://crrev.com/6da3286eca2180a66a6cb433f4d1f58f11011cfc
Cr-Commit-Position: refs/heads/master@{#388520}