Rename ignore_cache and ignoreCache to bypass* unless it affects API

Rename ignore_cache and ignoreCache to bypass* unless it affects API

Now ignore_cache and ignoreCache are going to be replaced with bypass*
in chromium/blink code base because there were wrong usage for the word
ignore, and it is very confusing to use.

But, DevTools exposes the word as a part of DevTools API for
Chrome Extensions and Remote Debuggers.

This change replace them as possible, but keep it as is if it affects
these APIs.

BUG=599364
TBR=pfeldman@chromium.org

Committed: https://crrev.com/e2262e257edc8cb45a5c1830250f740941ef9880
Cr-Commit-Position: refs/heads/master@{#386006}

[Takashi Toyoshima, 2016-04-06 09:34:49]

Description was changed from

==========
Rename ignore_cache and ignoreCache to bypass* unless it affects API

Now ignore_cache and ignoreCache are going to be replaced with bypass*
in chromium/blink code base because there were wrong usage for the word
ignore, and it is very confusing to use.

But, DevTools exposes the word as a part of DevTools API for
Chrome Extensions and Remote Debuggers.

This change replace them as possible, but keep it as is if it affects
these APIs.

BUG=599364
==========

to

==========
Rename ignore_cache and ignoreCache to bypass* unless it affects API

Now ignore_cache and ignoreCache are going to be replaced with bypass*
in chromium/blink code base because there were wrong usage for the word
ignore, and it is very confusing to use.

But, DevTools exposes the word as a part of DevTools API for
Chrome Extensions and Remote Debuggers.

This change replace them as possible, but keep it as is if it affects
these APIs.

BUG=599364
==========

[Takashi Toyoshima, 2016-04-06 09:34:49]

toyoshim@chromium.org changed reviewers:
+ dgozman@chromium.org

[Takashi Toyoshima, 2016-04-06 09:36:24]

Hi, I left some comments in this CL to get answers from reviewers.
Can you take a look?

https://codereview.chromium.org/1867523002/diff/1/chrome/common/extensions/ap...
File chrome/common/extensions/api/devtools/inspected_window.json (right):

https://codereview.chromium.org/1867523002/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/devtools/inspected_window.json:179: "ignoreCache":
{
I believe this "ignoreCache" should not be changed. Can you double check this?

https://codereview.chromium.org/1867523002/diff/1/chrome/common/extensions/do...
File
chrome/common/extensions/docs/examples/api/devtools/inspectedWindow/chrome-preprocessor/Panel/PreprocessorPanel.js
(right):

https://codereview.chromium.org/1867523002/diff/1/chrome/common/extensions/do...
chrome/common/extensions/docs/examples/api/devtools/inspectedWindow/chrome-preprocessor/Panel/PreprocessorPanel.js:29:
// TODO(toyoshim): Check if this ignoreCache shouldn't be changed for
I left some TODOs like this where I think the |ignoreCache| shouldn't be
renamed, but need someone's doublechecks.

https://codereview.chromium.org/1867523002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/externs.js (right):

https://codereview.chromium.org/1867523002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/externs.js:299: // DevTools
protocol. Also, how this prototype is used actually?
I can not find any caller that uses this function to instantiate new
ExtensionReloadOptions.
But this file is externs.js, so I guess this is exposed to external users in
some way?

[dgozman, 2016-04-06 15:44:20]

lgtm

https://codereview.chromium.org/1867523002/diff/1/chrome/common/extensions/do...
File
chrome/common/extensions/docs/examples/api/devtools/inspectedWindow/chrome-preprocessor/Panel/PreprocessorPanel.js
(right):

https://codereview.chromium.org/1867523002/diff/1/chrome/common/extensions/do...
chrome/common/extensions/docs/examples/api/devtools/inspectedWindow/chrome-preprocessor/Panel/PreprocessorPanel.js:29:
// TODO(toyoshim): Check if this ignoreCache shouldn't be changed for
On 2016/04/06 09:36:23, toyoshim wrote:
> I left some TODOs like this where I think the |ignoreCache| shouldn't be
> renamed, but need someone's doublechecks.

This is an example of public API usage, and should not be changed.
Note that placing TODO in examples is strange, since they are published to the
public.

https://codereview.chromium.org/1867523002/diff/1/chrome/test/chromedriver/ch...
File chrome/test/chromedriver/chrome/web_view_impl.cc (right):

https://codereview.chromium.org/1867523002/diff/1/chrome/test/chromedriver/ch...
chrome/test/chromedriver/chrome/web_view_impl.cc:194: // TODO(toyoshim): Check
if this ignoreCache shouldn't be changed for
This is a public API usage as well.

https://codereview.chromium.org/1867523002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/inspector/extensions-ignore-cache.html
(right):

https://codereview.chromium.org/1867523002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/inspector/extensions-ignore-cache.html:9:
// TODO(toyoshim): Probably keeping ignoreCache in this file as is will be
Correct.

https://codereview.chromium.org/1867523002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
(right):

https://codereview.chromium.org/1867523002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js:432:
// TODO(toyoshim): Check if this ignoreCache shouldn't be changed for
This is a public API.

https://codereview.chromium.org/1867523002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/externs.js (right):

https://codereview.chromium.org/1867523002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/externs.js:299: // DevTools
protocol. Also, how this prototype is used actually?
On 2016/04/06 09:36:23, toyoshim wrote:
> I can not find any caller that uses this function to instantiate new
> ExtensionReloadOptions.
> But this file is externs.js, so I guess this is exposed to external users in
> some way?

This is for type checking. It's mentioned in ExtensionServer.js, and we check
that fields accessed are as defined here. Should be left as is.

[Takashi Toyoshima, 2016-04-08 04:50:55]

https://codereview.chromium.org/1867523002/diff/1/chrome/common/extensions/do...
File
chrome/common/extensions/docs/examples/api/devtools/inspectedWindow/chrome-preprocessor/Panel/PreprocessorPanel.js
(right):

https://codereview.chromium.org/1867523002/diff/1/chrome/common/extensions/do...
chrome/common/extensions/docs/examples/api/devtools/inspectedWindow/chrome-preprocessor/Panel/PreprocessorPanel.js:29:
// TODO(toyoshim): Check if this ignoreCache shouldn't be changed for
Ah, yes. I just added TODOs for reviews, and will remove everything before
submitting.

https://codereview.chromium.org/1867523002/diff/1/chrome/test/chromedriver/ch...
File chrome/test/chromedriver/chrome/web_view_impl.cc (right):

https://codereview.chromium.org/1867523002/diff/1/chrome/test/chromedriver/ch...
chrome/test/chromedriver/chrome/web_view_impl.cc:194: // TODO(toyoshim): Check
if this ignoreCache shouldn't be changed for
On 2016/04/06 15:44:19, dgozman wrote:
> This is a public API usage as well.

Acknowledged.

https://codereview.chromium.org/1867523002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/inspector/extensions-ignore-cache.html
(right):

https://codereview.chromium.org/1867523002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/inspector/extensions-ignore-cache.html:9:
// TODO(toyoshim): Probably keeping ignoreCache in this file as is will be
On 2016/04/06 15:44:19, dgozman wrote:
> Correct.

Acknowledged.

https://codereview.chromium.org/1867523002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
(right):

https://codereview.chromium.org/1867523002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js:432:
// TODO(toyoshim): Check if this ignoreCache shouldn't be changed for
On 2016/04/06 15:44:19, dgozman wrote:
> This is a public API.

Acknowledged.

https://codereview.chromium.org/1867523002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/externs.js (right):

https://codereview.chromium.org/1867523002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/externs.js:299: // DevTools
protocol. Also, how this prototype is used actually?
Thanks!

[Takashi Toyoshima, 2016-04-08 04:52:31]

Description was changed from

==========
Rename ignore_cache and ignoreCache to bypass* unless it affects API

Now ignore_cache and ignoreCache are going to be replaced with bypass*
in chromium/blink code base because there were wrong usage for the word
ignore, and it is very confusing to use.

But, DevTools exposes the word as a part of DevTools API for
Chrome Extensions and Remote Debuggers.

This change replace them as possible, but keep it as is if it affects
these APIs.

BUG=599364
==========

to

==========
Rename ignore_cache and ignoreCache to bypass* unless it affects API

Now ignore_cache and ignoreCache are going to be replaced with bypass*
in chromium/blink code base because there were wrong usage for the word
ignore, and it is very confusing to use.

But, DevTools exposes the word as a part of DevTools API for
Chrome Extensions and Remote Debuggers.

This change replace them as possible, but keep it as is if it affects
these APIs.

BUG=599364
TBR=pfeldman@chromium.org
==========

[Takashi Toyoshima, 2016-04-08 04:53:49]

Add TBR=pfeldman@chromium.org for
chrome/common/extensions/api/devtools/inspected_window.json.
That's comment only change.

[Takashi Toyoshima, 2016-04-08 04:54:09]

The CQ bit was checked by toyoshim@chromium.org

[Takashi Toyoshima, 2016-04-08 04:54:10]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1867523002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-04-08 04:54:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867523002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867523002/40001

[commit-bot: I haz the power, 2016-04-08 06:22:29]

Description was changed from

==========
Rename ignore_cache and ignoreCache to bypass* unless it affects API

Now ignore_cache and ignoreCache are going to be replaced with bypass*
in chromium/blink code base because there were wrong usage for the word
ignore, and it is very confusing to use.

But, DevTools exposes the word as a part of DevTools API for
Chrome Extensions and Remote Debuggers.

This change replace them as possible, but keep it as is if it affects
these APIs.

BUG=599364
TBR=pfeldman@chromium.org
==========

to

==========
Rename ignore_cache and ignoreCache to bypass* unless it affects API

Now ignore_cache and ignoreCache are going to be replaced with bypass*
in chromium/blink code base because there were wrong usage for the word
ignore, and it is very confusing to use.

But, DevTools exposes the word as a part of DevTools API for
Chrome Extensions and Remote Debuggers.

This change replace them as possible, but keep it as is if it affects
these APIs.

BUG=599364
TBR=pfeldman@chromium.org
==========

[commit-bot: I haz the power, 2016-04-08 06:22:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-08 06:24:01]

Description was changed from

==========
Rename ignore_cache and ignoreCache to bypass* unless it affects API

Now ignore_cache and ignoreCache are going to be replaced with bypass*
in chromium/blink code base because there were wrong usage for the word
ignore, and it is very confusing to use.

But, DevTools exposes the word as a part of DevTools API for
Chrome Extensions and Remote Debuggers.

This change replace them as possible, but keep it as is if it affects
these APIs.

BUG=599364
TBR=pfeldman@chromium.org
==========

to

==========
Rename ignore_cache and ignoreCache to bypass* unless it affects API

Now ignore_cache and ignoreCache are going to be replaced with bypass*
in chromium/blink code base because there were wrong usage for the word
ignore, and it is very confusing to use.

But, DevTools exposes the word as a part of DevTools API for
Chrome Extensions and Remote Debuggers.

This change replace them as possible, but keep it as is if it affects
these APIs.

BUG=599364
TBR=pfeldman@chromium.org

Committed: https://crrev.com/e2262e257edc8cb45a5c1830250f740941ef9880
Cr-Commit-Position: refs/heads/master@{#386006}
==========

[commit-bot: I haz the power, 2016-04-08 06:24:02]

Patchset 3 (id:??) landed as
https://crrev.com/e2262e257edc8cb45a5c1830250f740941ef9880
Cr-Commit-Position: refs/heads/master@{#386006}