Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1006)

Unified Diff: content/browser/devtools/protocol/page_handler.cc

Issue 1867523002: Rename ignore_cache and ignoreCache to bypass* unless it affects API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/page_handler.cc
diff --git a/content/browser/devtools/protocol/page_handler.cc b/content/browser/devtools/protocol/page_handler.cc
index 5f71ef336086608b859d26f64a89433bee1e3bdf..d4f6c3976f4b77eef5192ffb0ac57f5a66dcd922 100644
--- a/content/browser/devtools/protocol/page_handler.cc
+++ b/content/browser/devtools/protocol/page_handler.cc
@@ -200,7 +200,7 @@ Response PageHandler::Disable() {
return Response::FallThrough();
}
-Response PageHandler::Reload(const bool* ignoreCache,
+Response PageHandler::Reload(const bool* bypassCache,
const std::string* script_to_evaluate_on_load,
const std::string* script_preprocessor) {
WebContentsImpl* web_contents = GetWebContents();
@@ -210,7 +210,10 @@ Response PageHandler::Reload(const bool* ignoreCache,
if (web_contents->IsCrashed() ||
(web_contents->GetController().GetVisibleEntry() &&
web_contents->GetController().GetVisibleEntry()->IsViewSourceMode())) {
- web_contents->GetController().Reload(false);
+ if (bypassCache && *bypassCache)
+ web_contents->GetController().ReloadBypassingCache(false);
+ else
+ web_contents->GetController().Reload(false);
return Response::OK();
} else {
// Handle reload in renderer except for crashed and view source mode.
« no previous file with comments | « content/browser/devtools/protocol/page_handler.h ('k') | third_party/WebKit/Source/core/inspector/InspectorPageAgent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698